Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tdesktop: 1.9.9 -> 1.9.12 #79867

Merged
merged 2 commits into from Feb 12, 2020
Merged

tdesktop: 1.9.9 -> 1.9.12 #79867

merged 2 commits into from Feb 12, 2020

Conversation

@primeos
Copy link
Member

@primeos primeos commented Feb 11, 2020

Status

Didn't test the executable yet (can do that tomorrow), but at least the build works. Ran fine so far.

Motivation for this change

cc @ilya-fedin FYI and it probably makes sense to collaborate on this update due to the two new dependencies (if we plan to package them in Nixpkgs).
I'm a bit low on time and didn't have time to package mapbox-variant (GH) if you want to try packaging it (but I suspect I'll be annoying to get it packaged as it uses a Makefile and some custom hacks that don't make sense for Nixpkgs/packaging) for kotatogram-desktop I can wait with this PR.

Update: Most likely there won't be a kotatogram-desktop release very soon.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
primeos added 2 commits Feb 11, 2020
This version is 5 commits ahead of version 1.0.0 because we need at
least one patch [0] that prevents CMake from trying to use Git to fetch
the already fetched submodule...
Also some files have the wrong formatting (CRLF line endings) which
makes the patching really messy. At this point is seems therefore better
to use the master version instead (1.0.0 is pretty broken regarding
CMake).

[0]: TartanLlama/expected@0ca73ee
Note: I skipped the packaging of mapbox-variant for now.
@primeos primeos force-pushed the primeos:tdesktop branch from ab2cd0d to d0729f8 Feb 11, 2020
@primeos primeos marked this pull request as ready for review Feb 11, 2020
@ofborg ofborg bot requested a review from abbradar Feb 12, 2020
@primeos primeos merged commit fc3f421 into NixOS:master Feb 12, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tdesktop, tl-expected on aarch64-linux Success
Details
tdesktop, tl-expected on x86_64-darwin Success
Details
tdesktop, tl-expected on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.