Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tdesktop: creates desktop item post install #79888

Closed
wants to merge 1 commit into from

Conversation

@ldelelis
Copy link
Contributor

@ldelelis ldelelis commented Feb 12, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@jtojnar jtojnar left a comment

I am confused why we would need this. Telegram already has a desktop file that is installed.

@ldelelis
Copy link
Contributor Author

@ldelelis ldelelis commented Feb 12, 2020

@jtojnar that wasn't the case for me at least. After installing tdesktop via home-manager, my drun launcher wasn't picking up a desktop item for Telegram. I'll investigate if it wasn't a one off issue however (or a configuration issue), and close this PR if it's necessary

@ldelelis
Copy link
Contributor Author

@ldelelis ldelelis commented Feb 13, 2020

Update: After installing though nixOS's default configuration, tdesktop's entry file exists and is available to drun launchers... I'll continue debugging this and see what the correct fix is.

@ldelelis ldelelis closed this Feb 13, 2020
@ldelelis ldelelis deleted the ldelelis:tdesktop-desktop-item branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.