Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: Added libdbusmenu support #79889

wants to merge 2 commits into
base: master


Copy link

@brcha brcha commented Feb 12, 2020

Motivation for this change

I wanted to enable global menus (appmenus, unity menus, dbusmenus, …) for VSCode and VSCodium. It's worth mentioning the issue: #65680

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits

As can be seen on the following screenshot, I've built the VSCode package and it now works with DBusMenus as it should. The only thing I did was to add libdbusmenu-gtk3 to dependencies in several places in the file. I've also tried to honor the Darwin target by adding libdbusmenu-gtk3 only where it didn't apply to Darwin, but, since I don't have a Mac to test this change, nor am I overly versed in Nix{,OS,Pkgs,…} ecosystem, I implore you to check that before accepting this push request. I'm guessing libdbusmenu doesn't work in Mac to provide global menus, but perhaps I'm wrong about that.


@ofborg ofborg bot requested a review from eadwu Feb 12, 2020
eadwu approved these changes Feb 12, 2020
Copy link

@peterhoeg peterhoeg commented May 2, 2020

@brcha any chance you can fix up the merge conflict so we can get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.