Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: add link to community chat options #79890

Merged
merged 1 commit into from Feb 12, 2020
Merged

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 12, 2020

Motivation for this change

The badge won't work until an admin (@zimbatm) enables it, but also open to removing the badge if it takes away from the original intent of the other badges.

related issues:
#79787

related discussion:
https://discourse.nixos.org/t/nixos-nixpkgs-nix-discord-for-voice-communication/5845/29

EDIT: just made a link to the wiki which has many other alternatives

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Feb 12, 2020

requested review from members that I could think of that have done other community outreach activities

Copy link
Member

@samueldr samueldr left a comment

This would open the door to the already existing established communities for all other services, in addition to the existing unofficial NixOS Discords listed here to want to add themselves to this list.

See this (probably incomplete) list:

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Feb 12, 2020

This would open the door to the already existing established communities for all other services, in addition to the existing unofficial NixOS Discords listed here to want to add themselves to this list.

Do you mind instead if I link to the the wiki page then? I didn't even know we had a discord until the thought of creating one crossed my mind.

@samueldr
Copy link
Member

@samueldr samueldr commented Feb 12, 2020

Do you mind instead if I link to the the wiki page then? I didn't even know we had a discord until the thought of creating one crossed my mind.

Adding it to the wiki: sure, go ahead, it's there for this purpose.

Adding the wiki link to the Get In Touch page to the README? I have no strong opinion about it either way. Though I think the wording needs to make it obvious these are additional community-led resources.

Copy link
Member

@ryantm ryantm left a comment

The badge seems way too official. I think linking to that wiki page is a good idea.

@jonringer jonringer force-pushed the jonringer:add-discord branch from de457b9 to 79262af Feb 12, 2020
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Feb 12, 2020

I just removed the badge, and just added a link to the the wiki

@jonringer jonringer force-pushed the jonringer:add-discord branch 2 times, most recently from 7ca4180 to 106f7e0 Feb 12, 2020
@jonringer jonringer changed the title readme: add discord link readme: add link to community chat options Feb 12, 2020
README.md Outdated Show resolved Hide resolved
@jonringer jonringer force-pushed the jonringer:add-discord branch from 106f7e0 to 12e392b Feb 12, 2020
README.md Outdated Show resolved Hide resolved
@jonringer jonringer force-pushed the jonringer:add-discord branch from 12e392b to 06bb5cc Feb 12, 2020
Copy link
Member

@worldofpeace worldofpeace left a comment

Love it

@worldofpeace worldofpeace merged commit 3cd8935 into NixOS:master Feb 12, 2020
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer jonringer deleted the jonringer:add-discord branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.