Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.jellybeans-vim: init at 2019-06-22 #79911

Merged
merged 2 commits into from Feb 12, 2020

Conversation

@xwvvvvwx
Copy link
Contributor

@xwvvvvwx xwvvvvwx commented Feb 12, 2020

Motivation for this change

Add jellybeans.vim

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@jonringer jonringer left a comment

To adhere to https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/vim.section.md#adding-new-plugins-to-nixpkgs, do you mind separating this into two commits?

vimPlugins: update
vimPlugins.jellybeans-vim: init at 2019-06-22

the update command should also contain the reordering of elements :)

xwvvvvwx added 2 commits Feb 12, 2020
@xwvvvvwx xwvvvvwx force-pushed the xwvvvvwx:jellybeans.vim branch from efa81c8 to d558c08 Feb 12, 2020
@xwvvvvwx
Copy link
Contributor Author

@xwvvvvwx xwvvvvwx commented Feb 12, 2020

done 🙂

Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM

failure is due to an upstream issue, and I think it will resolve itself as they've had a lot of activity recently

[156 built (1 failed), 56 copied (836.9 MiB), 172.7 MiB DL]
error: build of '/nix/store/d3krwbrb3h1mdr5ids9wbvn32ffrgka4-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/79911
1 package failed to build:
vimPlugins.far-vim

80 package built:
vimPlugins.nerdtree vimPlugins.YouCompleteMe vimPlugins.airline vimPlugins.ale vimPlugins.ansible-vim vimPlugins.calendar vimPlugins.coc-eslint vimPlugins.coc-git vimPlugins.coc-go vimPlugins.coc-html vimPlugins.coc-lists vimPlugins.coc-metals vimPlugins.coc-snippets vimPlugins.coc-tsserver vimPlugins.coc-yaml vimPlugins.csv vimPlugins.ctrlp vimPlugins.defx-icons vimPlugins.defx-nvim vimPlugins.denite vimPlugins.deoplete-jedi vimPlugins.easymotion vimPlugins.falcon vimPlugins.fastfold vimPlugins.ferret vimPlugins.fugitive vimPlugins.fzf-vim vimPlugins.jedi-vim vimPlugins.jellybeans-vim vimPlugins.julia-vim vimPlugins.lh-brackets vimPlugins.lightline-vim vimPlugins.multiple-cursors vimPlugins.ncm2 vimPlugins.ncm2-jedi vimPlugins.neomake vimPlugins.neomru vimPlugins.neosnippet vimPlugins.nvim-gdb vimPlugins.nvim-lsp vimPlugins.open-browser vimPlugins.open-browser-github-vim vimPlugins.quickrun vimPlugins.rust-vim vimPlugins.snipmate vimPlugins.tender-vim vimPlugins.unicode-vim vimPlugins.vim-addon-actions vimPlugins.vim-addon-background-cmd vimPlugins.vim-addon-goto-thing-at-cursor vimPlugins.vim-addon-mru vimPlugins.vim-addon-mw-utils vimPlugins.vim-addon-nix vimPlugins.vim-addon-other vimPlugins.vim-addon-syntax-checker vimPlugins.vim-addon-toggle-buffer vimPlugins.vim-addon-xdebug vimPlugins.vim-airline-themes vimPlugins.vim-asterisk vimPlugins.vim-autoformat vimPlugins.vim-better-whitespace vimPlugins.vim-devicons vimPlugins.vim-dispatch vimPlugins.vim-elixir vimPlugins.vim-go vimPlugins.vim-gutentags vimPlugins.vim-html-template-literals vimPlugins.vim-lsc vimPlugins.vim-parinfer vimPlugins.vim-racer vimPlugins.vim-sandwich vimPlugins.vim-snippets vimPlugins.vim-terraform vimPlugins.vim-themis vimPlugins.vim-visual-multi vimPlugins.vim-wakatime vimPlugins.vimtex vimPlugins.vista-vim vimPlugins.xptemplate vimPlugins.zig-vim
@jonringer jonringer merged commit 3e7ce1e into NixOS:master Feb 12, 2020
10 of 12 checks passed
10 of 12 checks passed
grahamcofborg-eval Calculating Changed Outputs
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 12, 2020

created an upstream issue brooth/far.vim#84

@timokau timokau mentioned this pull request Mar 25, 2020
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.