Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkdocs: default to Python 3 #79913

Merged
merged 1 commit into from Mar 6, 2020
Merged

mkdocs: default to Python 3 #79913

merged 1 commit into from Mar 6, 2020

Conversation

@jethrokuan
Copy link
Contributor

@jethrokuan jethrokuan commented Feb 12, 2020

Motivation for this change

mkdocs in master doesn't build. nix-shell -p mkdocs gives:

[jethro@jethro-desktop:~/nix-config/nixpkgs]$ nix-shell -p mkdocs
error: Django-2.2.10 not supported for interpreter python2.7
(use '--show-trace' to show detailed location information)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@FRidh FRidh left a comment

Please modify the parameter in development/tools/documentation/mkdocs/default.nix to python3 instead

@jethrokuan jethrokuan force-pushed the jethrokuan:fix/mkdocs branch from 2eb72fa to 54459af Feb 12, 2020
@jethrokuan
Copy link
Contributor Author

@jethrokuan jethrokuan commented Feb 12, 2020

I hope I did it right

@FRidh
FRidh approved these changes Feb 12, 2020
@ofborg ofborg bot requested a review from rkoe Feb 12, 2020
@jethrokuan
Copy link
Contributor Author

@jethrokuan jethrokuan commented Mar 6, 2020

Just bumping this.

@FRidh FRidh merged commit ee17a6a into NixOS:master Mar 6, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mkdocs on aarch64-linux Success
Details
mkdocs on x86_64-linux Success
Details
@jethrokuan jethrokuan deleted the jethrokuan:fix/mkdocs branch Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.