Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunderbird, thunderbird-bin: 68.4.2 -> 68.5.0 [High security fixes] #79917

Merged
merged 2 commits into from Feb 13, 2020

Conversation

@taku0
Copy link
Contributor

@taku0 taku0 commented Feb 12, 2020

Motivation for this change
  • High security fixes
  • Other improvements and fixes.

https://www.thunderbird.net/en-US/thunderbird/68.5.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2020-07/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@taku0
Copy link
Contributor Author

@taku0 taku0 commented Feb 12, 2020

For release-19.09: #79918

@vcunat
vcunat approved these changes Feb 12, 2020
Copy link
Member

@vcunat vcunat left a comment

Both seem to run fine for me.

On current master some dependencies of thunderbird need #79930 to build.

Copy link
Contributor

@lovesegfault lovesegfault left a comment

Tested and works :)

@flokli
Copy link
Contributor

@flokli flokli commented Feb 12, 2020

Thanks! For these fixes, please also file PRs, or ping @NixOS/backports so this will land in 20.03 as well.

vcunat added a commit that referenced this pull request Feb 13, 2020
@vcunat vcunat merged commit 64fe2b7 into NixOS:master Feb 13, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
thunderbird, thunderbird-bin on aarch64-linux Success
Details
thunderbird, thunderbird-bin on x86_64-linux Success
Details
@vcunat
Copy link
Member

@vcunat vcunat commented Feb 13, 2020

Re-tested for 20.03 as well and pushed as 7e10d60 and 0ce2f49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.