Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r128gain: 0.9.3 -> 1.0.1 #79924

Merged
merged 4 commits into from Feb 15, 2020
Merged

r128gain: 0.9.3 -> 1.0.1 #79924

merged 4 commits into from Feb 15, 2020

Conversation

@AluisioASG
Copy link
Contributor

@AluisioASG AluisioASG commented Feb 12, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @FRidh for mutagen update

@AluisioASG AluisioASG force-pushed the AluisioASG:aasg/r128gain branch from 8862fc9 to eefe881 Feb 12, 2020
@AluisioASG
Copy link
Contributor Author

@AluisioASG AluisioASG commented Feb 12, 2020

I still need to note in the commit message that I've switched to fetching r128gain from GitHub so I can run the tests locally with the sandbox disabled.

@AluisioASG AluisioASG force-pushed the AluisioASG:aasg/r128gain branch 2 times, most recently from 1a70531 to 6035289 Feb 13, 2020
Copy link
Contributor

@jonringer jonringer left a comment

seems to be a regression in the beets package

[47 built (2 failed), 176 copied (531.6 MiB), 153.6 MiB DL]
error: build of '/nix/store/nlqiwpvh7yc6xcpjljcvy2r9h38wj75z-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/79924
2 package failed to build:
beets mopidy-gmusic

30 package built:
cozy dir2opus gtkpod libgpod whipper mpdris2 nicotine-plus pantheon.elementary-music picard puddletag python27Packages.ffmpeg-python python27Packages.gmusicapi python27Packages.mutagen python27Packages.podcats python37Packages.ffmpeg-python python37Packages.gmusicapi python37Packages.mutagen python37Packages.podcats python38Packages.ffmpeg-python python38Packages.gmusicapi python38Packages.mutagen python38Packages.podcats quodlibet quodlibet-full quodlibet-without-gst-plugins quodlibet-xine quodlibet-xine-full r128gain rofi-mpd split2flac

master:

[09:26:06] jon@jon-desktop /home/jon/projects/nixpkgs (master)
$ nix-build -A beets
/nix/store/dimbvay1js4amf0fhsf2n25g94ywwmlz-beets-1.4.9
@AluisioASG
Copy link
Contributor Author

@AluisioASG AluisioASG commented Feb 13, 2020

It's beetbox/mediafile#24. I'm backporting beetbox/mediafile@b3343c4 to beets so it works with the new mutagen.

AluisioASG added 4 commits Feb 11, 2020
Not updating to 1.44.0 due to it dropping Python 2 support.
Switched the source to GitHub so that test files are available for
local, unsandboxed testing.
@AluisioASG AluisioASG force-pushed the AluisioASG:aasg/r128gain branch from 6035289 to 98e2817 Feb 13, 2020
@AluisioASG
Copy link
Contributor Author

@AluisioASG AluisioASG commented Feb 13, 2020

Fixed and rebased. mopidy-gmusic is unrelated as it also fails to build on master.

cc @aszlig @domenkozar @pjones for Beets patch

@ofborg ofborg bot requested review from domenkozar, pjones and aszlig Feb 13, 2020
Copy link
Contributor

@jonringer jonringer left a comment

this also seems to cause a regression in cozy due to the mutagen bump:
before

# opens gui

after

$ ./results/cozy/bin/cozy

** (gst-plugin-scanner:12503): CRITICAL **: 18:09:50.844: Couldn't g_module_open libpython. Reason: /nix/store/g20g00saxyssz0ka1xcmcm31bfq6iq31-python3-3.7.6/lib/python3.7/config-3.7m-x86_64-linux-gnu/libpython3.7m.so: cannot open shared object file: No such file or directory

** (gst-plugin-scanner:12503): CRITICAL **: 18:09:50.849: Couldn't g_module_open libpython. Reason: /nix/store/g20g00saxyssz0ka1xcmcm31bfq6iq31-python3-3.7.6/lib/python3.7/config-3.7m-x86_64-linux-gnu/libpython3.7m.so: cannot open shared object file: No such file or directory

** (gst-plugin-scanner:12503): CRITICAL **: 18:09:50.851: Couldn't g_module_open libpython. Reason: /nix/store/g20g00saxyssz0ka1xcmcm31bfq6iq31-python3-3.7.6/lib/python3.7/config-3.7m-x86_64-linux-gnu/libpython3.7m.so: cannot open shared object file: No such file or directory

** (gst-plugin-scanner:12503): CRITICAL **: 18:09:50.852: Couldn't g_module_open libpython. Reason: /nix/store/g20g00saxyssz0ka1xcmcm31bfq6iq31-python3-3.7.6/lib/python3.7/config-3.7m-x86_64-linux-gnu/libpython3.7m.so: cannot open shared object file: No such file or directory
['/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/bin/.com.github.geigi.cozy-wrapped']
/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/bin/..com.github.geigi.cozy-wrapped-wrapped:60: PyGIDeprecationWarning: Since version 3.11, calling threads_init is no longer needed. See: https://wiki.gnome.org/PyGObject/Threading
  GObject.threads_init()
/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/bin/..com.github.geigi.cozy-wrapped-wrapped:71: DeprecationWarning: dist() and linux_distribution() functions are deprecated in Python 3.5
  log.info(platform.dist())
18:09:52 [MainThread  ] [main      ] [INFO ]  ('', '', '')
18:09:52 [MainThread  ] [main      ] [INFO ]  Starting up cozy 0.6.7
Traceback (most recent call last):
  File "/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/lib/python3.7/site-packages/cozy/db.py", line 390, in update_db
    next(c for c in db.get_columns("settings") if c.name == "version")
StopIteration

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/bin/..com.github.geigi.cozy-wrapped-wrapped", line 74, in do_startup
    init_db()
  File "/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/lib/python3.7/site-packages/cozy/db.py", line 129, in init_db
    update_db()
  File "/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/lib/python3.7/site-packages/cozy/db.py", line 397, in update_db
    update_db_1()
  File "/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/lib/python3.7/site-packages/cozy/db.py", line 299, in update_db_1
    migrator.add_column('track', 'crc32', crc32),
  File "/nix/store/gk55vzpdqh8b090q7yipr7gr3qzdr3gv-python3.7-peewee-3.11.2/lib/python3.7/site-packages/playhouse/migrate.py", line 823, in migrate
    operation.run()
  File "/nix/store/gk55vzpdqh8b090q7yipr7gr3qzdr3gv-python3.7-peewee-3.11.2/lib/python3.7/site-packages/playhouse/migrate.py", line 160, in run
    self._handle_result(method(*self.args, **kwargs))
  File "/nix/store/gk55vzpdqh8b090q7yipr7gr3qzdr3gv-python3.7-peewee-3.11.2/lib/python3.7/site-packages/playhouse/migrate.py", line 154, in _handle_result
    self._handle_result(item)
  File "/nix/store/gk55vzpdqh8b090q7yipr7gr3qzdr3gv-python3.7-peewee-3.11.2/lib/python3.7/site-packages/playhouse/migrate.py", line 151, in _handle_result
    result.run()
  File "/nix/store/gk55vzpdqh8b090q7yipr7gr3qzdr3gv-python3.7-peewee-3.11.2/lib/python3.7/site-packages/playhouse/migrate.py", line 160, in run
    self._handle_result(method(*self.args, **kwargs))
  File "/nix/store/gk55vzpdqh8b090q7yipr7gr3qzdr3gv-python3.7-peewee-3.11.2/lib/python3.7/site-packages/playhouse/migrate.py", line 151, in _handle_result
    result.run()
  File "/nix/store/gk55vzpdqh8b090q7yipr7gr3qzdr3gv-python3.7-peewee-3.11.2/lib/python3.7/site-packages/playhouse/migrate.py", line 160, in run
    self._handle_result(method(*self.args, **kwargs))
  File "/nix/store/gk55vzpdqh8b090q7yipr7gr3qzdr3gv-python3.7-peewee-3.11.2/lib/python3.7/site-packages/playhouse/migrate.py", line 168, in inner
    return fn(self, *args, **kwargs)
  File "/nix/store/gk55vzpdqh8b090q7yipr7gr3qzdr3gv-python3.7-peewee-3.11.2/lib/python3.7/site-packages/playhouse/migrate.py", line 644, in _update_column
    (column_to_update, table))
ValueError: Column "version" does not exist on "settings"

(.com.github.geigi.cozy-wrapped:12480): GLib-GIO-CRITICAL **: 18:09:52.525: GApplication subclass '__main__+Application' failed to chain up on ::startup (from start of override function)
18:09:52 [MainThread  ] [ui        ] [INFO ]  Initialize main window
Traceback (most recent call last):
  File "/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/bin/..com.github.geigi.cozy-wrapped-wrapped", line 79, in do_activate
    self.ui.activate()
  File "/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/lib/python3.7/site-packages/cozy/ui.py", line 59, in activate
    self.__init_window()
  File "/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/lib/python3.7/site-packages/cozy/ui.py", line 128, in __init_window
    self.window = self.window_builder.get_object("app_window")
AttributeError: 'CozyUI' object has no attribute 'window_builder'

(.com.github.geigi.cozy-wrapped:12480): GLib-GIO-CRITICAL **: 18:09:52.527: GApplication subclass '__main__+Application' failed to chain up on ::shutdown (from end of override function)
@AluisioASG
Copy link
Contributor Author

@AluisioASG AluisioASG commented Feb 15, 2020

Hmm, I'm unable to replicate that.

$ realpath result
/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7

$ nix-store -q --tree result | grep mutagen
+---/nix/store/10bdsywv56bmkrljv3wa65516813qp2s-python3.7-mutagen-1.43.0
|   +---/nix/store/10bdsywv56bmkrljv3wa65516813qp2s-python3.7-mutagen-1.43.0 [...]

This is what I get when I run it on KDE for the first time and import a few files (with duplicated lines removed):

$ result/bin/cozy                                                                                                                                                                           

** (gst-plugin-scanner:11314): CRITICAL **: 23:37:25.344: Couldn't g_module_open libpython. Reason: /nix/store/g20g00saxyssz0ka1xcmcm31bfq6iq31-python3-3.7.6/lib/python3.7/config-3.7m-x86_64-linux-gnu/libpython3.7m.so: cannot open shared object file: No such file or directory

['/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/bin/.com.github.geigi.cozy-wrapped']
/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/bin/..com.github.geigi.cozy-wrapped-wrapped:60: PyGIDeprecationWarning: Since version 3.11, calling threads_init is no longer needed. See: https://wiki.gnome.org/PyGObject/Threading
  GObject.threads_init()
/nix/store/gmfi2f3415k9xjppgn7rly5zzk0xsm2j-cozy-0.6.7/bin/..com.github.geigi.cozy-wrapped-wrapped:71: DeprecationWarning: dist() and linux_distribution() functions are deprecated in Python 3.5
  log.info(platform.dist())
23:37:25 [MainThread  ] [main      ] [INFO ]  ('', '', '')
23:37:25 [MainThread  ] [main      ] [INFO ]  Starting up cozy 0.6.7
23:37:26 [MainThread  ] [ui        ] [INFO ]  Initialize main window
23:37:26 [Thread-2    ] [offline_ca] [INFO ]  Startet processing queue
23:37:26 [UpdateDataba] [importer  ] [INFO ]  Total import time: 0.0004296302795410156
23:37:26 [UpdateDataba] [offline_ca] [INFO ]  Startet processing queue

(.com.github.geigi.cozy-wrapped:11310): dconf-WARNING **: 23:37:49.711: failed to commit changes to dconf: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name ca.desrt.dconf was not provided by any .service files

23:37:52 [UpdateDataba] [importer  ] [INFO ]  Total import time: 3.0040740966796875e-05
23:37:52 [UpdateDataba] [offline_ca] [INFO ]  Startet processing queue
23:39:36 [UpdateDataba] [importer  ] [INFO ]  Total import time: 0.025415420532226562
23:39:36 [UpdateDataba] [offline_ca] [INFO ]  Startet processing queue
23:39:45 [UpdateDataba] [importer  ] [INFO ]  Total import time: 0.016440391540527344
23:39:46 [UpdateDataba] [offline_ca] [INFO ]  Startet processing queue
23:39:54 [MainThread  ] [player    ] [INFO ]  Closing.
23:39:59 [MainThread  ] [ui        ] [INFO ]  Closing.
23:39:59 [MainThread  ] [titlebar  ] [INFO ]  Closing.
23:39:59 [MainThread  ] [player    ] [INFO ]  Closing.
23:39:59 [MainThread  ] [db        ] [INFO ]  Closing.
23:39:59 [MainThread  ] [ui        ] [INFO ]  Closing app.
23:39:59 [MainThread  ] [ui        ] [INFO ]  App closed.

I can close it, reopen, and play a file with no issues.

I also tried erasing all data, running the pre-upgrade version (/nix/store/zhn0y1l8w4bjr4zjw7d2rjrga2a72qaq-cozy-0.6.7), and then running the post-upgrade version (seeing as it is database-related), but it worked all the same.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 15, 2020

I also don't have a DE, so that may be contributing

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 15, 2020

hmm, cozy works fine on a different computer. No idea.

Copy link
Contributor

@jonringer jonringer left a comment

LGTM
commits LGTM

[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79924
31 package built:
beets cozy dir2opus gtkpod libgpod mpdris2 nicotine-plus pantheon.elementary-music picard puddletag python27Packages.ffmpeg-python python27Packages.gmusicapi python27Packages.mutagen python27Packages.podcats python37Packages.ffmpeg-python python37Packages.gmusicapi python37Packages.mutagen python37Packages.podcats python38Packages.ffmpeg-python python38Packages.gmusicapi python38Packages.mutagen python38Packages.podcats quodlibet quodlibet-full quodlibet-without-gst-plugins quodlibet-xine quodlibet-xine-full r128gain rofi-mpd split2flac whipper
@jonringer jonringer merged commit 6f24be1 into NixOS:master Feb 15, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
beets, r128gain on aarch64-linux Success
Details
beets, r128gain on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.