Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mate: update to version 1.24.0 #79939

Merged
merged 47 commits into from Feb 18, 2020
Merged

mate: update to version 1.24.0 #79939

merged 47 commits into from Feb 18, 2020

Conversation

@romildo
Copy link
Contributor

@romildo romildo commented Feb 12, 2020

Motivation for this change

Update to version 1.24.0.

Announcement.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 13, 2020

Will review @romildo, happy to say #71427 got fixed recently.
It's unfortunate this happened right after 20.03 branch off.

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 13, 2020

Could you still reproduce #75447? I couldn't in the vm.

Currently marco is crashing

Feb 13 21:54:25 nixos .marco-wrapped[1036]: Settings schema 'org.mate.peripherals-mouse' is not installed
Copy link
Member

@worldofpeace worldofpeace left a comment

There's another important news item.

i18n: All applications have been migrated from intltools to gettext.

You need to remove intiltool for gettext in every expression.

@worldofpeace worldofpeace added this to the 20.09 milestone Feb 13, 2020
@worldofpeace worldofpeace mentioned this pull request Feb 13, 2020
3 of 10 tasks complete
Settings schema 'org.mate.peripherals-mouse' is needed by marco-1.24.x
and is provided by mate-settings-daemon.
@romildo
Copy link
Contributor Author

@romildo romildo commented Feb 14, 2020

Could you still reproduce #75447? I couldn't in the vm.

I cannot reproduce it. I have closed the issue now.

Currently marco is crashing

Feb 13 21:54:25 nixos .marco-wrapped[1036]: Settings schema 'org.mate.peripherals-mouse' is not installed

Fixed.

@romildo
Copy link
Contributor Author

@romildo romildo commented Feb 14, 2020

There's another important news item.

i18n: All applications have been migrated from intltools to gettext.

You need to remove intiltool for gettext in every expression.

Done.

@romildo
Copy link
Contributor Author

@romildo romildo commented Feb 14, 2020

There's another important news item.

i18n: All applications have been migrated from intltools to gettext.

You need to remove intiltool for gettext in every expression.

Done.

You're missing mate-settings-daemon in marco.

Fixed.

I did also notice they ported several projects to using meson

* https://github.com/mate-desktop/mate-desktop/blob/master/meson.build

* https://github.com/mate-desktop/marco/blob/master/meson.build

* https://github.com/mate-desktop/mate-backgrounds/blob/master/meson.build

* https://github.com/mate-desktop/mozo/blob/master/meson.build

It'd be cool to port to them.

The meson.build files are not being distributed in the source *.tar.xz files, although they are available at the git repository.

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 14, 2020

The meson.build files are not being distributed in the source *.tar.xz files, although they are available at the git repository.

Aww, that sucks. It's pretty weird they'd mention it but not distribute it. Perhaps they consider it experimental.

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 14, 2020

@romildo mate-user-guide doesn't launch in the session.
Looking at the desktop file

Exec=yelp help:mate-user-guide

You need to install yelp in mate.nix.
I'm pretty sure it has an impurity that it has to be in systemPackages.

Copy link
Member

@worldofpeace worldofpeace left a comment

^ See above comment.

@romildo
Copy link
Contributor Author

@romildo romildo commented Feb 14, 2020

@romildo mate-user-guide doesn't launch in the session.
Looking at the desktop file

Exec=yelp help:mate-user-guide

You need to install yelp in mate.nix.
I'm pretty sure it has an impurity that it has to be in systemPackages.

Wouldn't it be enough to use the full path for yelp in the desktop file?

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 14, 2020

@romildo mate-user-guide doesn't launch in the session.
Looking at the desktop file

Exec=yelp help:mate-user-guide

You need to install yelp in mate.nix.
I'm pretty sure it has an impurity that it has to be in systemPackages.

Wouldn't it be enough to use the full path for yelp in the desktop file?

That's because we do it in the gnome3 module

As stated in

I'm pretty sure it has an impurity that it has to be in systemPackages.

That's just from remembrance though. You could try it.

@romildo
Copy link
Contributor Author

@romildo romildo commented Feb 14, 2020

Wouldn't it be enough to use the full path for yelp in the desktop file?

That's because we do it in the gnome3 module

As stated in

I'm pretty sure it has an impurity that it has to be in systemPackages.

That's just from remembrance though. You could try it.

The user guide works when the full path to yelp is used in the desktop file.

But it seems that yelp in $PATH is needed for 'Contents' in 'Help' menus of the applications.

romildo added 2 commits Feb 14, 2020
Without this the Contents item in the Help menu of applications fails
to launch.
Copy link
Member

@worldofpeace worldofpeace left a comment

I believe this is good 👍
I haven't QA'd very much.
(I did start every app briefly, which is when I noticed the mate-user-guide thing)

@romildo romildo merged commit 0bcd9a5 into NixOS:master Feb 18, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.