Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal-desktop: fix notifications #79949

Merged
merged 1 commit into from Feb 12, 2020

Conversation

@puckipedia
Copy link
Contributor

@puckipedia puckipedia commented Feb 12, 2020

Motivation for this change

Because Electron, Signal Desktop doesn't actually directly link to libnotify, and dynamically loads it, which caused #77850 to break notifications. This adds libnotify to the runtime deps, bringing notifications back.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace worldofpeace merged commit 2d80e40 into NixOS:master Feb 12, 2020
1 check was pending
1 check was pending
grahamcofborg-eval Checking original out paths
Details
@puckipedia puckipedia mentioned this pull request Feb 12, 2020
1 of 10 tasks complete
@ofborg ofborg bot requested review from primeos, ixmatus and equirosa Feb 12, 2020
@primeos
Copy link
Member

@primeos primeos commented Feb 12, 2020

@puckipedia nice, thanks for the fix :)

primeos added a commit that referenced this pull request Feb 13, 2020
(cherry picked from commit 0b3e5db)
Reason: Backport of #79949 to fix the notifications.
pull bot added a commit to Frostman/nixpkgs that referenced this pull request Feb 16, 2020
(cherry picked from commit 0b3e5db)
Reason: Backport of NixOS#79949 to fix the notifications.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.