Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ell,iwd: 0.28, 1.5, minor touchups, drop tmpfiles snippet #79961

Merged
merged 5 commits into from Feb 13, 2020

Conversation

@dtzWill
Copy link
Contributor

@dtzWill dtzWill commented Feb 13, 2020

Motivation for this change

See commits, but:

  • ell: 0.27 -> 0.28
  • iwd: 1.4 -> 1.5
  • iwd: drop systemd dep, not needed when specifying config flags too
  • iwd: tests, openssl check dep

NixOS module:

  • drop tmpfiles snippet, this shouldn't be needed due to StateDirectory directives in service fails AFAIK?
  • Add myself to maintainers list too :)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
dtzWill added 4 commits Feb 13, 2020
Only used to guess if systemd-y bits should be installed,
which we manually specify already.  So drop unneeded dep.
Originally added in [1], and iwd added StateDirectory to its services
in [2] -- 4 days later.

("StateDirectory wasn't used when tmpfile snippet was added to NixOS")
(nevermind git -> release delay)

[1] 6e54e92
[2] upstream iwd git rev: 71ae0bee9c6320dae0083ed8c1700bc8fff1defb
@dtzWill dtzWill changed the title ell,iwd: 0.28, 1.5, minor touchups ell,iwd: 0.28, 1.5, minor touchups, drop tmpfiles snippet Feb 13, 2020
@dtzWill
Copy link
Contributor Author

@dtzWill dtzWill commented Feb 13, 2020

The tmpfiles change was inspired by similar recently made elsewhere-- speak up if there's any push-back there :).

@Mic92 Mic92 merged commit b300ccd into NixOS:master Feb 13, 2020
16 checks passed
16 checks passed
ell, iwd on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
ell, iwd on aarch64-linux Success
Details
ell, iwd on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Feb 13, 2020

Thanks!

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Feb 13, 2020

The tmpfiles change was inspired by similar recently made elsewhere-- speak up if there's any push-back there :).

Yes. This should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.