Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.imgaug: 0.3.0 -> 0.4.0 #79982

Merged
merged 1 commit into from Feb 13, 2020
Merged

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 13, 2020

Motivation for this change

noticed the current package is broken from the pandas update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
[8 built, 1 copied (0.9 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79982
2 package built:
python37Packages.imgaug python38Packages.imgaug
@jonringer jonringer requested a review from FRidh as a code owner Feb 13, 2020
@ofborg ofborg bot added the 6.topic: python label Feb 13, 2020
@ofborg ofborg bot requested review from CMCDragonkai and Rakesh4G Feb 13, 2020
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Feb 13, 2020

This fixes a broken build, merging

@jonringer jonringer merged commit 9ad3ee2 into NixOS:master Feb 13, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer jonringer deleted the jonringer:bump-imgaug branch Feb 13, 2020
@Rakesh4G
Copy link
Contributor

@Rakesh4G Rakesh4G commented Feb 14, 2020

Hi @jonringer
By ignoring only one augmenter file test_imgcorruptlike.py, all other tests are passing without requiring anything extra.
pytest ./test --ignore=test/augmenters/test_imgcorruptlike.py
5031 passed, 4 skipped in 212.86s (0:03:32)
as compare to ignoring augmenter totally
1832 passed, 2 skipped in 35.22s
@CMCDragonkai
imgaug_tests.txt

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Feb 14, 2020

if you would like to open a PR I would be happy to accept it. I was fixing a lot of packages yesterday:
#79990
#79989
#79986
#79985
#79982
#79958
#79869

@Rakesh4G
Copy link
Contributor

@Rakesh4G Rakesh4G commented Feb 14, 2020

@jonringer No worries. I will open a PR. in between trying to see if i can get some solution for test/augmenters/test_imgcorruptlike.py

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.