Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.numba: disable for python < 3.6 #79988

Merged
merged 1 commit into from Feb 13, 2020
Merged

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 13, 2020

Motivation for this change
builder for '/nix/store/y3c1y8z9p262pmc2zica46nfal22m5aa-python2.7-numba-0.48.0.drv' failed with exit code 1; last 10 log lines:
  no configure script, doing nothing
  building
  Executing setuptoolsBuildPhase
  Traceback (most recent call last):
    File "nix_run_setup", line 8, in <module>
      exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
    File "setup.py", line 305
      build_requires = [f'numpy >={min_numpy_build_version}']
                                                           ^
  SyntaxError: invalid syntax
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer jonringer requested a review from FRidh as a code owner Feb 13, 2020
@FRidh FRidh merged commit 984eb94 into NixOS:master Feb 13, 2020
@jonringer jonringer deleted the jonringer:fix-numba branch Feb 13, 2020
@FRidh
Copy link
Member

@FRidh FRidh commented Feb 13, 2020

will you backport?

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Feb 13, 2020

sure

@jonringer jonringer mentioned this pull request Feb 13, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.