Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elisa: move into kdeApplications #80003

Merged
merged 1 commit into from Apr 7, 2020
Merged

elisa: move into kdeApplications #80003

merged 1 commit into from Apr 7, 2020

Conversation

@peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Feb 13, 2020

Motivation for this change

elisa is now part of the upstream kdeApplications bundle

We should however not merge this until kde applications 19.12.2 hits master as this PR would otherwise downgrade elisa.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
elisa is now part of the upstream kdeApplications bundle
@peterhoeg peterhoeg force-pushed the peterhoeg:f/elisa branch from 9f3b3e6 to 0c7ec50 Apr 7, 2020
@peterhoeg
Copy link
Member Author

@peterhoeg peterhoeg commented Apr 7, 2020

Merging since #83897 was merged.

@peterhoeg peterhoeg merged commit d7b9812 into NixOS:master Apr 7, 2020
@peterhoeg peterhoeg deleted the peterhoeg:f/elisa branch Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.