Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoom-us: fix launch #80005

Merged
merged 2 commits into from Feb 14, 2020
Merged

zoom-us: fix launch #80005

merged 2 commits into from Feb 14, 2020

Conversation

@danbst
Copy link
Contributor

danbst commented Feb 13, 2020

Probably due to glibc update, ZoomLauncher became broken when v4l is present in
LD_PRELOAD path. It can be fixed by a) removing ZoomLauncher from startup chain,
so zoom is started directly or b) removing v4l from LD_PRELOAD.

The reason v4l was added before was because my video was rotated upside down without it.
Seem like nowadays this is fixed by Zoom itself, so I'm disabling it.

Fixes #79954

Co-authored-by: @mmlb

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Probably due to glibc update, ZoomLauncher became broken when v4l is present in
LD_PRELOAD path. It can be fixed by a) removing ZoomLauncher from startup chain,
so `zoom` is started directly or b) removing v4l from LD_PRELOAD.

The reason v4l was added before was because my video was rotated upside down without it.
Seem like nowadays this is fixed by Zoom itself, so I'm disabling it.

Fixes #79954

Co-authored-by: @mmlb
@matthewbauer

This comment has been minimized.

Copy link
Member

matthewbauer commented Feb 13, 2020

It might make sense to just remove the LD_PRELOAD line. This was needed to support some webcams which aren't the proper pixel format expected in libv4l1 apps. The one I hit this with was the logitech C310. Those might be fixed in zoom-us anyway.

See https://wiki.archlinux.org/index.php/Webcam_setup#V4L1_support

@mmlb

This comment has been minimized.

Copy link
Contributor

mmlb commented Feb 13, 2020

tested and works for me.

@danbst danbst merged commit 854638e into NixOS:master Feb 14, 2020
1 check was pending
1 check was pending
grahamcofborg-eval Cloning project
Details
@danbst danbst deleted the danbst:zoom-v4l-fix branch Feb 14, 2020
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Feb 14, 2020
zoom-us: fix launch

Probably due to glibc update, ZoomLauncher became broken when v4l is present in
LD_PRELOAD path. It can be fixed by a) removing ZoomLauncher from startup chain,
so `zoom` is started directly or b) removing v4l from LD_PRELOAD.

The reason v4l was added before was because my video was rotated upside down without it.
Seem like nowadays this is fixed by Zoom itself, so I'm removing it.

Fixes NixOS#79954

Co-authored-by: @mmlb
(cherry picked from commit 854638e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.