Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport-19.09] zfs: 0.8.2 -> 0.8.3 #80008

Merged
merged 4 commits into from Mar 2, 2020
Merged

Conversation

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Feb 13, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Mic92 and others added 4 commits Oct 2, 2019
At the moment we experience bad instabilities with linux 5.3:

openzfs/zfs#9346

as the zfs-native method of disabling the FPU is buggy.

(cherry picked from commit 96097ab)
(cherry picked from commit 539e66c)
(cherry picked from commit 17f76a9)
(cherry picked from commit 88de34b)
@Mic92 Mic92 mentioned this pull request Feb 13, 2020
6 of 10 tasks complete
@Mic92 Mic92 changed the title zfs: 0.8.2 -> 0.8.3 [backport-19.09] zfs: 0.8.2 -> 0.8.3 Feb 13, 2020
@Mic92 Mic92 mentioned this pull request Feb 13, 2020
0 of 10 tasks complete
@Frostman
Copy link
Member

@Frostman Frostman commented Feb 13, 2020

@Mic92 shouldn't be 5.4 patched as well? Thx

@Mic92
Copy link
Contributor Author

@Mic92 Mic92 commented Feb 13, 2020

There is no dedicated linux-5.4 package in 19.09, however linux-latest == linux-5.4.

@Frostman
Copy link
Member

@Frostman Frostman commented Feb 28, 2020

I've tested it on my system (x86_64, kernel 5.4.x) and it works fine, I've applied that patch to my custom nixpkgs branch.

@Mic92 Mic92 merged commit 84f47bf into NixOS:release-19.09 Mar 2, 2020
16 checks passed
16 checks passed
linux, zfs, zfsUnstable on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
linux, zfs, zfsUnstable on aarch64-linux Success
Details
linux, zfs, zfsUnstable on x86_64-linux Success
Details
@Mic92 Mic92 deleted the Mic92:fpu-backport branch Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.