Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-cloud-sdk: fix gsutil startup crash #80010

Merged
merged 2 commits into from Feb 18, 2020
Merged

Conversation

@edef1c
Copy link
Member

@edef1c edef1c commented Feb 13, 2020

This fixes #79754, by removing the two places where the tests are referenced by runtime code.

There's still a bunch of chaff that we could cull left, although it won't buy us much in closure size:

edef@vixen ~> rg -li '^(from.*tests.*import|import.*test)' (nix-build '<nixpkgs>' -A google-cloud-sdk --no-out-link) | wc -l
63
edef@vixen ~> du -ch (rg -li '^(from.*tests.*import|import.*test)' (nix-build '<nixpkgs>' -A google-cloud-sdk --no-out-link)) | tail -n1
858K	total
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.
@edef1c
Copy link
Member Author

@edef1c edef1c commented Feb 13, 2020

Since #79250 seems to have made it into https://github.com/NixOS/nixpkgs/releases/tag/20.03-beta, this'll need a backport.

@edef1c edef1c requested a review from flokli Feb 13, 2020
@edef1c edef1c force-pushed the edef1c:fix-gsutil-crash branch from b4bde97 to 0c9a075 Feb 13, 2020
@ofborg ofborg bot requested review from zimbatm and pradyuman Feb 13, 2020
edef1c added 2 commits Feb 13, 2020
The update checking mechanism references the tests, and thus
dbaafbb turned it into a crash at
startup.

It isn't much use in nixpkgs, so we're better off without it.
The command module references the tests, and since all command modules
get imported at startup, dbaafbb
turned it into a startup crash.

Unless you're actively hacking on gsutil, this command isn't much use,
so we're better off without it.
@edef1c edef1c closed this Feb 18, 2020
@edef1c edef1c force-pushed the edef1c:fix-gsutil-crash branch from 0c9a075 to f8c8f52 Feb 18, 2020
@edef1c edef1c reopened this Feb 18, 2020
@flokli flokli merged commit ac1e949 into NixOS:master Feb 18, 2020
16 checks passed
16 checks passed
google-cloud-sdk on aarch64-linux No attempt
Details
google-cloud-sdk on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
google-cloud-sdk on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@flokli
Copy link
Contributor

@flokli flokli commented Feb 18, 2020

backported to 20.03 in 45217d0 and 370505a.

@edef1c edef1c deleted the edef1c:fix-gsutil-crash branch Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.