Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

romdirfs: init at 1.2 #80013

Merged
merged 1 commit into from Mar 9, 2020
Merged

romdirfs: init at 1.2 #80013

merged 1 commit into from Mar 9, 2020

Conversation

@bignaux
Copy link
Contributor

@bignaux bignaux commented Feb 13, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Mentioned on https://nixos.wiki/wiki/Playstation2#PCSX2

@bignaux
Copy link
Contributor Author

@bignaux bignaux commented Feb 13, 2020

@GrahamcOfBorg build romdirfs

Copy link
Contributor

@aanderse aanderse left a comment

Seems pretty straightforward. I'll try to give this a quick test today. Aside from the one requested change we're probably good to go 👍

As always, sorry for the delay.

pkgs/tools/filesystems/romdirfs/default.nix Outdated Show resolved Hide resolved
Bignaux Ronan
@bignaux bignaux force-pushed the bignaux:romdirfs branch from a03e9c8 to a201e3d Mar 8, 2020
Copy link
Contributor

@aanderse aanderse left a comment

I thought I had a ps2 bios somewhere but I don't. Oh well... it builds and executes a help menu fine. You tried it out, so all good here. Thanks!

@aanderse aanderse merged commit 2c61263 into NixOS:master Mar 9, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
romdirfs on aarch64-linux Success
Details
romdirfs on x86_64-linux Success
Details
@bignaux bignaux deleted the bignaux:romdirfs branch Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.