Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncurses: 6.1-20190112 -> 6.2 #80016

Merged
merged 1 commit into from Mar 6, 2020
Merged

ncurses: 6.1-20190112 -> 6.2 #80016

merged 1 commit into from Mar 6, 2020

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Feb 13, 2020

https://invisible-island.net/ncurses/announce-6.2.html

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@zowoq zowoq force-pushed the zowoq:ncurses branch from 3af3268 to ff6e298 Feb 13, 2020
@zowoq zowoq force-pushed the zowoq:ncurses branch from ff6e298 to 4db7e54 Feb 13, 2020
@FRidh
Copy link
Member

@FRidh FRidh commented Feb 16, 2020

@GrahamcOfBorg build stdenv python3

@FRidh FRidh moved this from WIP to Needs review in Staging Feb 16, 2020
name = "ncurses-${version}" + lib.optionalString (abiVersion == "5") "-abi5-compat";

# We cannot use fetchFromGitHub (which calls fetchzip)
# because we need to be able to use fetchurlBoot.
src = let
# Note the version needs to be adjusted.
rev = "acb4184f8f69fddd052a3daa8c8675f4bf8ce369";
rev = "v${version}";
in fetchurl {
url = "https://github.com/mirror/ncurses/archive/${rev}.tar.gz";

This comment has been minimized.

@mmilata

mmilata Feb 17, 2020
Member

What do you think about fetching this directly from https://ftp.gnu.org/gnu/ncurses/ncurses-6.2.tar.gz instead of third party mirror?

This comment has been minimized.

@FRidh

FRidh Feb 17, 2020
Member

At least development versions got removed often, see 43e867a.

@FRidh FRidh merged commit bb0d036 into NixOS:staging Mar 6, 2020
18 checks passed
18 checks passed
python3, stdenv on x86_64-darwin Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ncurses on aarch64-linux Success
Details
ncurses on x86_64-linux Success
Details
python3, stdenv on aarch64-linux Success
Details
python3, stdenv on x86_64-linux Success
Details
Staging automation moved this from Needs review to Done Mar 6, 2020
@zowoq zowoq deleted the zowoq:ncurses branch Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.