Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.bayesian-optimization: init at 1.0.1 #80017

Merged
merged 1 commit into from Feb 18, 2020

Conversation

@juliendehos
Copy link
Contributor

@juliendehos juliendehos commented Feb 13, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@jonringer jonringer left a comment

please ensure that unit tests are being packaged through pypi and ran.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 13, 2020

please squash commits, in accordance to CONTRIBUTING

git reset HEAD~3
git add pkgs/
git commit --amend --no-edit
git push .. .. --force
@juliendehos juliendehos force-pushed the juliendehos:bayesian-optimization branch from 118dde2 to 54ee9af Feb 13, 2020
@juliendehos
Copy link
Contributor Author

@juliendehos juliendehos commented Feb 13, 2020

I've added pytest but nix-build says "Ran 0 tests" and I don't know why (it seems that the tests folder is not present when the test phase is run).

@juliendehos juliendehos force-pushed the juliendehos:bayesian-optimization branch from 54ee9af to 0c8f75c Feb 14, 2020
@juliendehos juliendehos force-pushed the juliendehos:bayesian-optimization branch from 0c8f75c to c03b4b5 Feb 17, 2020
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
commit LGTM
has tests 👍

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80017
3 package built:
python27Packages.bayesian-optimization python37Packages.bayesian-optimization python38Packages.bayesian-optimization
@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 18, 2020

@GrahamcOfBorg build python27Packages.bayesian-optimization python37Packages.bayesian-optimization python38Packages.bayesian-optimization

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 18, 2020

darwin failure unrelated to PR

@jonringer jonringer merged commit 60c4596 into NixOS:master Feb 18, 2020
16 checks passed
16 checks passed
python27Packages.bayesian-optimization, python37Packages.bayesian-optimization, python38Packages.bayesian-optimization on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.bayesian-optimization, python37Packages.bayesian-optimization, python38Packages.bayesian-optimization on aarch64-linux Success
Details
python27Packages.bayesian-optimization, python37Packages.bayesian-optimization, python38Packages.bayesian-optimization on x86_64-linux Success
Details
@juliendehos juliendehos deleted the juliendehos:bayesian-optimization branch Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.