Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c3d: unbreak via stdenv -> gcc8Stdenv #80046

Merged
merged 1 commit into from Feb 13, 2020
Merged

Conversation

@bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Feb 13, 2020

Motivation for this change

c3d was unbroken by #72046 when that PR was created, but by the time it was merged this week it was broken again by GCC 9.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 13, 2020

This should also be backported to 20.03 if it's broken there as well (was branched Feb 10).

Copy link
Member

@worldofpeace worldofpeace left a comment

Can you mark this as broken on aarch64-linux?
AFAICT, it's never built there https://hydra.nixos.org/job/nixpkgs/trunk/c3d.aarch64-linux/all.

meta = {
  ...
  broken = stdenv.isAarch64;
};

A comment with the error would be cool too.

/build/git-3453f61/itkextras/OneDimensionalInPlaceAccumulateFilter.txx:311:10: fatal error: xmmintrin.h: No such file or directory
 #include <xmmintrin.h>

^ it seems it can't find a header that's in gcc on that platform.

@bcdarwin bcdarwin force-pushed the bcdarwin:c3d-downgrade-gcc branch from 36f3969 to 1112bcc Feb 13, 2020
@bcdarwin
Copy link
Member Author

@bcdarwin bcdarwin commented Feb 13, 2020

@worldofpeace -- done, thanks.

@worldofpeace worldofpeace merged commit 05f5786 into NixOS:master Feb 13, 2020
@bcdarwin bcdarwin deleted the bcdarwin:c3d-downgrade-gcc branch Feb 13, 2020
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 13, 2020

backports done in dee6990
95bf506. Thanks @bcdarwin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.