Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.docker-tools: Port to Python #80048

Merged
merged 1 commit into from Feb 28, 2020

Conversation

@tfc
Copy link
Contributor

@tfc tfc commented Feb 13, 2020

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@tfc
Copy link
Contributor Author

@tfc tfc commented Feb 13, 2020

@GrahamcOfBorg test docker-tools

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 14, 2020

A new test case got added baa78de

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 14, 2020

cc @nlewo

@nlewo
Copy link
Member

@nlewo nlewo commented Feb 15, 2020

@tfc I've rebased your commit onto master in nlewo@09112bc. So, you could just pick this commit and push force your branch to update this PR ;)
And thanks for this PR!

@tfc tfc force-pushed the tfc:port-docker-tools-test branch from c2709f6 to 6bb849d Feb 15, 2020
@tfc
Copy link
Contributor Author

@tfc tfc commented Feb 15, 2020

@nlewo thank you! did so.

@worldofpeace i put the time string into a variable. does this fix your concern?

@tfc
Copy link
Contributor Author

@tfc tfc commented Feb 15, 2020

@GrahamcOfBorg test docker-tools

@tfc tfc force-pushed the tfc:port-docker-tools-test branch from 6bb849d to 0a49699 Feb 27, 2020
@tfc
Copy link
Contributor Author

@tfc tfc commented Feb 27, 2020

@GrahamcOfBorg test docker-tools

@nlewo
nlewo approved these changes Feb 27, 2020
Copy link
Member

@nlewo nlewo left a comment

Would be nice to merge it soon because one more test is arriving ;)

@worldofpeace worldofpeace merged commit 2e89e0d into NixOS:master Feb 28, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.docker-tools on aarch64-linux Success
Details
tests.docker-tools on x86_64-linux Success
Details
@nlewo
Copy link
Member

@nlewo nlewo commented Feb 28, 2020

Thanks!

@tfc tfc deleted the tfc:port-docker-tools-test branch Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.