Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mono: fix build w/glibc-2.30 #80050

Merged
merged 1 commit into from Feb 13, 2020
Merged

mono: fix build w/glibc-2.30 #80050

merged 1 commit into from Feb 13, 2020

Conversation

@ajs124
Copy link
Member

@ajs124 ajs124 commented Feb 13, 2020

Motivation for this change

Fixes #79841

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ajs124 ajs124 requested a review from FRidh Feb 13, 2020
@Ma27
Ma27 approved these changes Feb 13, 2020
@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 13, 2020

@GrahamcOfBorg build mono

Copy link
Contributor

@jonringer jonringer left a comment

seeing as this is broken on master, building the linux version is still a marked improvement.

The darwin build, if still failing, can be dealt with in another PR.

@jonringer jonringer merged commit c30b4a7 into NixOS:master Feb 13, 2020
15 of 16 checks passed
15 of 16 checks passed
mono on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mono on aarch64-linux Success
Details
mono on x86_64-linux Success
Details
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 13, 2020

Backport to 20.03?

@minijackson
Copy link
Contributor

@minijackson minijackson commented Feb 13, 2020

A bit late probably, but:

Result of nix-review pr 80050 1

14 package failed to build:
  • dotnetPackages.FSharpAutoComplete (keepass-keepassrpc)
  • dotnetPackages.FSharpCompilerService (keepass-keepassrpc)
  • foundationdb51 (keepass-keepassrpc)
  • foundationdb52 (keepass-keepassrpc)
  • foundationdb60 (keepass-keepassrpc)
  • python27Packages.foundationdb51 (keepass-keepassrpc)
  • python27Packages.foundationdb52 (keepass-keepassrpc)
  • python27Packages.foundationdb60 (keepass-keepassrpc)
  • python37Packages.foundationdb51 (keepass-keepassrpc)
  • python37Packages.foundationdb52 (keepass-keepassrpc)
  • python37Packages.foundationdb60 (keepass-keepassrpc)
  • python38Packages.foundationdb51 (keepass-keepassrpc)
  • python38Packages.foundationdb52 (keepass-keepassrpc)
  • python38Packages.foundationdb60 (keepass-keepassrpc)
128 package were built:
  • avrdudess (keepass-keepassrpc)
  • bless (keepass-keepassrpc)
  • boogie (keepass-keepassrpc)
  • ckan (keepass-keepassrpc)
  • convchain (keepass-keepassrpc)
  • dafny (keepass-keepassrpc)
  • dbus-sharp-1_0 (keepass-keepassrpc)
  • dbus-sharp-2_0 (keepass-keepassrpc)
  • dbus-sharp-glib-1_0 (keepass-keepassrpc)
  • dbus-sharp-glib-2_0 (keepass-keepassrpc)
  • dotnetPackages.Autofac (keepass-keepassrpc)
  • dotnetPackages.Deedle (keepass-keepassrpc)
  • dotnetPackages.ExcelDna (keepass-keepassrpc)
  • dotnetPackages.ExcelDnaRegistration (keepass-keepassrpc)
  • dotnetPackages.FSharpCompilerCodeDom (keepass-keepassrpc)
  • dotnetPackages.FSharpCompilerTools (keepass-keepassrpc)
  • dotnetPackages.FSharpCore302 (keepass-keepassrpc)
  • dotnetPackages.FSharpCore3125 (keepass-keepassrpc)
  • dotnetPackages.FSharpCore4001 (keepass-keepassrpc)
  • dotnetPackages.FSharpCore4117 (keepass-keepassrpc)
  • dotnetPackages.FSharpData (keepass-keepassrpc)
  • dotnetPackages.FSharpData225 (keepass-keepassrpc)
  • dotnetPackages.FSharpDataSQLProvider (keepass-keepassrpc)
  • dotnetPackages.FSharpFormatting (keepass-keepassrpc)
  • dotnetPackages.Fake (keepass-keepassrpc)
  • dotnetPackages.Fantomas (keepass-keepassrpc)
  • dotnetPackages.FsCheck (keepass-keepassrpc)
  • dotnetPackages.FsCheck262 (keepass-keepassrpc)
  • dotnetPackages.FsCheckNunit (keepass-keepassrpc)
  • dotnetPackages.FsLexYacc (keepass-keepassrpc)
  • dotnetPackages.FsLexYacc706 (keepass-keepassrpc)
  • dotnetPackages.FsLexYaccRuntime (keepass-keepassrpc)
  • dotnetPackages.FsPickler (keepass-keepassrpc)
  • dotnetPackages.FsUnit (keepass-keepassrpc)
  • dotnetPackages.FuzzyLogicLibrary (keepass-keepassrpc)
  • dotnetPackages.GitVersionTree (keepass-keepassrpc)
  • dotnetPackages.MathNetNumerics (keepass-keepassrpc)
  • dotnetPackages.MaxMindDb (keepass-keepassrpc)
  • dotnetPackages.MaxMindGeoIP2 (keepass-keepassrpc)
  • dotnetPackages.MicrosoftDiaSymReader (keepass-keepassrpc)
  • dotnetPackages.MicrosoftDiaSymReaderPortablePdb (keepass-keepassrpc)
  • dotnetPackages.MonoAddins (keepass-keepassrpc)
  • dotnetPackages.MonoNat (keepass-keepassrpc)
  • dotnetPackages.NDeskOptions (keepass-keepassrpc)
  • dotnetPackages.NUnit (keepass-keepassrpc)
  • dotnetPackages.NUnit3 (keepass-keepassrpc)
  • dotnetPackages.NUnit350 (keepass-keepassrpc)
  • dotnetPackages.NUnitConsole (keepass-keepassrpc)
  • dotnetPackages.NUnitRunners (keepass-keepassrpc)
  • dotnetPackages.NewtonsoftJson (keepass-keepassrpc)
  • dotnetPackages.Nuget (keepass-keepassrpc)
  • dotnetPackages.OpenNAT (keepass-keepassrpc)
  • dotnetPackages.Paket (keepass-keepassrpc)
  • dotnetPackages.Projekt (keepass-keepassrpc)
  • dotnetPackages.RestSharp (keepass-keepassrpc)
  • dotnetPackages.SharpFont (keepass-keepassrpc)
  • dotnetPackages.SharpZipLib (keepass-keepassrpc)
  • dotnetPackages.SmartIrc4net (keepass-keepassrpc)
  • dotnetPackages.StyleCopMSBuild (keepass-keepassrpc)
  • dotnetPackages.StyleCopPlusMSBuild (keepass-keepassrpc)
  • dotnetPackages.Suave (keepass-keepassrpc)
  • dotnetPackages.SystemCollectionsImmutable (keepass-keepassrpc)
  • dotnetPackages.SystemCollectionsImmutable131 (keepass-keepassrpc)
  • dotnetPackages.SystemReflectionMetadata (keepass-keepassrpc)
  • dotnetPackages.SystemValueTuple (keepass-keepassrpc)
  • dotnetPackages.UnionArgParser (keepass-keepassrpc)
  • dotnetbuildhelpers (keepass-keepassrpc)
  • duplicati (keepass-keepassrpc)
  • eventstore (keepass-keepassrpc)
  • foundationdb (keepass-keepassrpc)
  • fsharp (keepass-keepassrpc)
  • fsharp41 (keepass-keepassrpc)
  • gio-sharp (keepass-keepassrpc)
  • gnome-sharp (keepass-keepassrpc)
  • gtk-sharp-2_0 (keepass-keepassrpc)
  • gtk-sharp-beans (keepass-keepassrpc)
  • haxePackages.hxcs (keepass-keepassrpc)
  • hyena (keepass-keepassrpc)
  • keepass (keepass-keepassrpc)
  • keepass-keeagent (keepass-keepassrpc)
  • keepass-keefox (keepass-keepassrpc)
  • keepass-keepasshttp (keepass-keepassrpc)
  • keepass-otpkeyprov (keepass-keepassrpc)
  • kodiPlugins.steam-launcher (keepass-keepassrpc)
  • lidarr (keepass-keepassrpc)
  • linux-steam-integration (keepass-keepassrpc)
  • lutris (keepass-keepassrpc)
  • midisheetmusic (keepass-keepassrpc)
  • mono (keepass-keepassrpc)
  • mono-addins (keepass-keepassrpc)
  • mono4 (keepass-keepassrpc)
  • mono6 (keepass-keepassrpc)
  • msbuild (keepass-keepassrpc)
  • omnisharp-roslyn (keepass-keepassrpc)
  • openra (keepass-keepassrpc)
  • openraPackages.engines.bleed (keepass-keepassrpc)
  • openraPackages.engines.playtest (keepass-keepassrpc)
  • openraPackages.mods.ca (keepass-keepassrpc)
  • openraPackages.mods.d2 (keepass-keepassrpc)
  • openraPackages.mods.dr (keepass-keepassrpc)
  • openraPackages.mods.gen (keepass-keepassrpc)
  • openraPackages.mods.kknd (keepass-keepassrpc)
  • openraPackages.mods.mw (keepass-keepassrpc)
  • openraPackages.mods.ra2 (keepass-keepassrpc)
  • openraPackages.mods.raclassic (keepass-keepassrpc)
  • openraPackages.mods.rv (keepass-keepassrpc)
  • openraPackages.mods.sp (keepass-keepassrpc)
  • openraPackages.mods.ss (keepass-keepassrpc)
  • openraPackages.mods.ura (keepass-keepassrpc)
  • openraPackages.mods.yr (keepass-keepassrpc)
  • pash (keepass-keepassrpc)
  • pdfmod (keepass-keepassrpc)
  • pinta (keepass-keepassrpc)
  • python27Packages.foundationdb61 (keepass-keepassrpc)
  • python37Packages.foundationdb61 (keepass-keepassrpc)
  • python38Packages.foundationdb61 (keepass-keepassrpc)
  • radarr (keepass-keepassrpc)
  • scallion (keepass-keepassrpc)
  • sonarr (keepass-keepassrpc)
  • steam (keepass-keepassrpc)
  • steam-run (keepass-keepassrpc)
  • steam-run-native (keepass-keepassrpc)
  • steamcmd (keepass-keepassrpc)
  • supertux-editor (keepass-keepassrpc)
  • syntex (keepass-keepassrpc)
  • taglib-sharp (keepass-keepassrpc)
  • tomboy (keepass-keepassrpc)
  • wavefunctioncollapse (keepass-keepassrpc)

FoundationDB errors are unrelated (c++ compilation failure) and FSharpCompilerService also probably unrelated. The rest of the failures depends on these two.

logs of FSharpCompilerService

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 13, 2020

The logs that there was some build QA done is still helpful, though, @minijackson.

@ajs124 ajs124 deleted the helsinki-systems:fix/mono branch Feb 13, 2020
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 14, 2020

backported to 20.03 in 10c6239 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.