Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitAndTools.bump2version: init at 1.0.0 #80053

Merged
merged 1 commit into from Feb 15, 2020

Conversation

@JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Feb 13, 2020

Motivation for this change

I need it at my work to bump my versions in my software

Things done

Create a new package to install in python 3 bump2version from Pypi

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@JeffLabonte JeffLabonte requested review from FRidh and jonringer as code owners Feb 13, 2020
Copy link
Contributor

@jonringer jonringer left a comment

please clean up git history, you have 3 irrelevant commits

@JeffLabonte JeffLabonte force-pushed the JeffLabonte:init_pythonPackage_bump2version branch from f086445 to 94d7f05 Feb 13, 2020
@JeffLabonte
Copy link
Contributor Author

@JeffLabonte JeffLabonte commented Feb 13, 2020

I was just doing the cleanup when you left the comment! That was fast!

@ofborg ofborg bot added the 6.topic: python label Feb 13, 2020
Copy link
Member

@cole-h cole-h left a comment

A small nitpick, but it would be nice if you could modify your commit message to match the specification found in CONTRIBUTING.md.

E.g. bump2version: init at 1.0.0 See below.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 13, 2020

It should be the installable path (the full path to the package). For python packages, it should be:

pythonPackages.bump2version: init at 1.0.0

using interpreter specific version is also fine, if needed to differentiate

python3Packages.bump2version: init at 1.0.0
@JeffLabonte JeffLabonte force-pushed the JeffLabonte:init_pythonPackage_bump2version branch from d721e7e to fe95b2d Feb 14, 2020
@JeffLabonte
Copy link
Contributor Author

@JeffLabonte JeffLabonte commented Feb 14, 2020

I preferred to use the latter since this packages doesn't have a support available for python 2.7 anymore.

@JeffLabonte JeffLabonte requested a review from jonringer Feb 14, 2020
@jonringer jonringer changed the title Init python package bump2version python3Packages.bump2version: init at 1.0.0 Feb 14, 2020
Copy link
Contributor

@jonringer jonringer left a comment

Stepping back, I think this package is mean to be used through it' cli. If it's mean to be a command-line utility, it doesn't really need to go to into python-modules.

It could just be included in gitAndTools, and do something like:

  bump2version = python3.pkgs.callPackage ./bump2version { };
@JeffLabonte JeffLabonte force-pushed the JeffLabonte:init_pythonPackage_bump2version branch 3 times, most recently from 89af557 to 513906f Feb 14, 2020
@JeffLabonte
Copy link
Contributor Author

@JeffLabonte JeffLabonte commented Feb 14, 2020

Make sense to move the package to gitAndTools, i made the change!

@JeffLabonte
Copy link
Contributor Author

@JeffLabonte JeffLabonte commented Feb 14, 2020

What would be the path in my commit message then ? @jonringer

@ofborg ofborg bot removed the 6.topic: python label Feb 14, 2020
Copy link
Contributor

@jonringer jonringer left a comment

commit message would be:

gitAndTools.bump2version: init at 1.0.0
@JeffLabonte JeffLabonte force-pushed the JeffLabonte:init_pythonPackage_bump2version branch from 513906f to 8523200 Feb 15, 2020
@JeffLabonte
Copy link
Contributor Author

@JeffLabonte JeffLabonte commented Feb 15, 2020

Thank @jonringer ! You allowed me to learn a few more things!

Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
commit LGTM
has tests 👍

[3 built, 1 copied (0.7 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80053
1 package built:
gitAndTools.bump2version
@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 15, 2020

@GrahamcOfBorg build gitAndTools.bump2version

@jonringer jonringer changed the title python3Packages.bump2version: init at 1.0.0 gitAndTools.bump2version: init at 1.0.0 Feb 15, 2020
@jonringer jonringer merged commit ebf01d5 into NixOS:master Feb 15, 2020
13 of 15 checks passed
13 of 15 checks passed
grahamcofborg-eval Calculating Changed Outputs
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
gitAndTools.bump2version on aarch64-linux Success
Details
gitAndTools.bump2version on x86_64-darwin Success
Details
gitAndTools.bump2version on x86_64-linux Success
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.