Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/mate: use upstream session #80066

Merged
merged 3 commits into from Mar 23, 2020
Merged

Conversation

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 13, 2020

Motivation for this change

#79939

Things done

Tested in #79939.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace worldofpeace requested review from jtojnar and romildo Feb 13, 2020
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Feb 13, 2020

Same caveat as the Xfce sessions.

@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Feb 13, 2020

I also noticed that the XDG_CURRENT_DESKTOP won't be right even with #79830. It's MATE in mate.desktop. So this would obviously fix that.

Same caveat as the Xfce sessions.

😦 If only this was a wayland-sessions.

@worldofpeace worldofpeace force-pushed the worldofpeace:mate-upstream branch from aa6db9e to af73425 Feb 18, 2020
@ofborg ofborg bot requested a review from romildo Feb 18, 2020
Copy link
Contributor

@romildo romildo left a comment

LGTM. Tested on a VM.

@ilya-fedin
Copy link
Contributor

@ilya-fedin ilya-fedin commented Feb 24, 2020

Any news? 🤔

@worldofpeace worldofpeace merged commit a82c39f into NixOS:master Mar 23, 2020
16 checks passed
16 checks passed
mate.mate-session-manager on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mate.mate-session-manager on aarch64-linux Success
Details
mate.mate-session-manager on x86_64-linux Success
Details
@worldofpeace worldofpeace deleted the worldofpeace:mate-upstream branch Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.