Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.plotinus: Port to Python #80067

Merged
merged 1 commit into from Feb 13, 2020
Merged

Conversation

@tfc
Copy link
Contributor

@tfc tfc commented Feb 13, 2020

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@tfc tfc requested review from flokli and worldofpeace Feb 13, 2020
@tfc
Copy link
Contributor Author

@tfc tfc commented Feb 13, 2020

@GrahamcOfBorg test plotinus

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 13, 2020

We seriously have a lot of things for this program 16fa6f5#diff-03391cc228e4f3d0fe2f38d6af3abf9e.

@worldofpeace worldofpeace merged commit 694a8b2 into NixOS:master Feb 13, 2020
1 of 2 checks passed
1 of 2 checks passed
tests.plotinus on x86_64-linux
Details
tests.plotinus on aarch64-linux Success
Details
@tfc tfc deleted the tfc:port-plotinus-test branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.