Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: 80.0.3987.100 -> 80.0.3987.106 #80074

Merged
merged 2 commits into from Feb 15, 2020
Merged

chromium: 80.0.3987.100 -> 80.0.3987.106 #80074

merged 2 commits into from Feb 15, 2020

Conversation

@primeos
Copy link
Member

primeos commented Feb 14, 2020

https://chromereleases.googleblog.com/2020/02/stable-channel-update-for-desktop_13.html

Motivation for this change
platform attribute status tester
x86_64 chromium ✔️ @Frostman and @primeos
x86_64 nixosTests.chromium ✔️ @Frostman
x86_64 google-chrome ✔️ @primeos
aarch64 chromium ✔️ @thefloweringash
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Frostman

This comment has been minimized.

Copy link
Member

Frostman commented Feb 14, 2020

nixpkgs-review -p nixosTests.chromium passed ok (x86_64)

primeos added a commit that referenced this pull request Feb 14, 2020
@thefloweringash

This comment has been minimized.

Copy link
Member

thefloweringash commented Feb 15, 2020

LGTM on aarch64. Tested: general browsing, youtube video playback.

See 3fadc45. Since the beta channel is now also on 81 and the stable
channel will be on 81 soon, it makes sense to already add this
unconditionally for all channels.
@primeos

This comment has been minimized.

Copy link
Member Author

primeos commented Feb 15, 2020

@Frostman @thefloweringash Awesome, thanks for testing it :)

@primeos primeos merged commit 53fd2da into NixOS:master Feb 15, 2020
primeos added a commit that referenced this pull request Feb 15, 2020
See 3fadc45. Since the beta channel is now also on 81 and the stable
channel will be on 81 soon, it makes sense to already add this
unconditionally for all channels.

(cherry picked from commit 67f349d)
Backport of #80074.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.