Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rxvt-unicode-plugins.perls: 2.2 -> 2.3 #80089

Merged
merged 2 commits into from Feb 14, 2020
Merged

Conversation

@ivanbrennan
Copy link
Member

ivanbrennan commented Feb 14, 2020

Motivation for this change

Version 2.3 of urxvt-perls adds a useful option to the keyboard-select plugin:

URxvt.keyboard-select.clipboard: If true, copy to clipboard too

meaning pressing y or Return will yank the selected text into the clipboard in addition to the primary selection.

This version also deprecates the clipboard and url-select plugins, as versions 9.20 and 9.21 of urxvt made them unnecessary. In the first commit, I removed these plugins, but then thought better of it, as many users are likely still using them, so I added them back in the second commit.
https://github.com/muennich/urxvt-perls/blob/master/deprecated/README.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
ivanbrennan added 2 commits Feb 14, 2020
This upgrade brings a new option to the keyboard-select plugin:

  URxvt.keyboard-select.clipboard: If true, copy to clipboard too

and removes the now deprecated clipboard and url-select plugins. The
reasons for deprecating these two plugins are described at:
https://github.com/muennich/urxvt-perls/blob/master/deprecated/README.md
While the clipboard and url-select plugins have been deprecated, it's
likely there are still many users expecting them to exist, so continue
to provide them.

https://github.com/muennich/urxvt-perls/blob/master/deprecated/README.md
Copy link
Contributor

rnhmjoj left a comment

Looks good. Thank you.

@rnhmjoj rnhmjoj merged commit 30bc292 into NixOS:master Feb 14, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ivanbrennan ivanbrennan deleted the ivanbrennan:urxvt-perls-update branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.