Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.rsyslogd: Port to python #80096

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@tfc
Copy link
Contributor

tfc commented Feb 14, 2020

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@tfc tfc requested review from flokli and worldofpeace Feb 14, 2020
@tfc

This comment has been minimized.

Copy link
Contributor Author

tfc commented Feb 14, 2020

@GrahamcOfBorg test rsyslogd

@flokli

This comment has been minimized.

Copy link
Contributor

flokli commented Feb 18, 2020

cc @aanderse - it seems it's not properly added to all-tests.nix.

@aanderse

This comment has been minimized.

Copy link
Contributor

aanderse commented Feb 19, 2020

cc @aanderse - it seems it's not properly added to all-tests.nix.

@flokli reviewing my own PR history on this it seems I had added this test to the list of all tests. I'd have to dig to find out when it was removed, and by who.

@flokli

This comment has been minimized.

Copy link
Contributor

flokli commented Feb 22, 2020

@aanderse sorry, seems I was mistaken here - it does exist in current master, and has since the introduction of all-tests.nix at least.

@flokli

This comment has been minimized.

Copy link
Contributor

flokli commented Feb 22, 2020

From the look of it, handleTest seems to have a problem with files returning an attrset of tests. @Infinisil, do you know what's going on here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.