Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.imgaug: 0.4.0 - Fixed disabled/broken augmenters tests #80098

Merged
merged 1 commit into from Feb 15, 2020

Conversation

@Rakesh4G
Copy link
Contributor

Rakesh4G commented Feb 14, 2020

Motivation for this change

pythonPackages.imgaug: 0.4.0 - Fixed disabled/broken augmenters tests
fixes disabled tests from : #79982
Tests pass post changes.
imgaug_tests.txt

Depends upon: #80095

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
    @CMCDragonkai @jonringer
@Rakesh4G Rakesh4G mentioned this pull request Feb 14, 2020
1 of 10 tasks complete
@ofborg ofborg bot added the 6.topic: python label Feb 14, 2020
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Feb 15, 2020

do you mind rebasing?

@Rakesh4G

This comment has been minimized.

Copy link
Contributor Author

Rakesh4G commented Feb 15, 2020

do you mind rebasing?

Sure. I am doing it.

@Rakesh4G Rakesh4G force-pushed the formbay:imgaug-0.4.0-tests-fix branch from 948d14a to 921ef83 Feb 15, 2020
@Rakesh4G Rakesh4G marked this pull request as ready for review Feb 15, 2020
@Rakesh4G Rakesh4G requested review from FRidh and jonringer as code owners Feb 15, 2020
@ofborg ofborg bot requested a review from CMCDragonkai Feb 15, 2020
@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Feb 15, 2020

@GrahamcOfBorg build python3Packages.imgaug

Copy link
Contributor

jonringer left a comment

LGTM

@jonringer jonringer merged commit e94a84a into NixOS:master Feb 15, 2020
16 checks passed
16 checks passed
python3Packages.imgaug on aarch64-linux Timed out, unknown build status
Details
python3Packages.imgaug on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python3Packages.imgaug on x86_64-linux Success
Details
@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Feb 16, 2020

Hey, just a heads up here the commit message didn't match the contribution guidelines, but the pr title did. e94a84a

pythonPackages.imgaug: fix broken augmenters tests
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Feb 16, 2020

ah, my bad didn't really check since the PR was titled correctly

@Rakesh4G

This comment has been minimized.

Copy link
Contributor Author

Rakesh4G commented Feb 17, 2020

Hey, just a heads up here the commit message didn't match the contribution guidelines

@worldofpeace @jonringer , Sorry. I will keep this in mind. Thanks again.

@Rakesh4G Rakesh4G deleted the formbay:imgaug-0.4.0-tests-fix branch Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.