Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.systemd-confinement: Port to Python #80103

wants to merge 1 commit into
base: master


Copy link

tfc commented Feb 14, 2020

Motivation for this change


Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits

This comment has been minimized.

Copy link
Contributor Author

tfc commented Feb 14, 2020

@GrahamcOfBorg test systemd-confinement

Copy link

worldofpeace left a comment

Looks nice 👍

__testSteps = lib.mkOrder num (''

This comment has been minimized.

Copy link

flokli Feb 18, 2020


Can we inline whatever this is doing? I assume the outcome will be much more understandable, instead of using nix as a template language here to write python code…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.