Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-cli: init at 0.5.5 #80110

Closed
wants to merge 1 commit into from
Closed

github-cli: init at 0.5.5 #80110

wants to merge 1 commit into from

Conversation

@michaelpj
Copy link
Contributor

michaelpj commented Feb 14, 2020

Motivation for this change

There's a new Github cli.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@zowoq

This comment has been minimized.

Copy link
Contributor

zowoq commented Feb 14, 2020

Already packaged as: gitAndTools.gh

@michaelpj

This comment has been minimized.

Copy link
Contributor Author

michaelpj commented Feb 14, 2020

Hm, I looked, but evidently not on a new enough version!

@michaelpj michaelpj closed this Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.