Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.robotframework-debuglibrary: init at 1.2 #80134

Open
wants to merge 1 commit into
base: master
from

Conversation

@talkara
Copy link
Contributor

talkara commented Feb 14, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@talkara talkara requested review from FRidh and jonringer as code owners Feb 14, 2020
prompt-toolkit-version-1 = prompt_toolkit.overrideAttrs (oldAttrs: rec {
version = "1.0.18";
src = fetchPypi {
inherit version;
pname = oldAttrs.pname;
sha256 = "dd4fca02c8069497ad931a2d09914c6b0d1b50151ce876bc15bde4c747090126";
};
});
Comment on lines 11 to 18

This comment has been minimized.

Copy link
@jonringer

jonringer Feb 14, 2020

Contributor

overriding versions in python-modules isn't allowed, as it can create incoherent package sets

This comment has been minimized.

Copy link
@talkara

talkara Feb 14, 2020

Author Contributor

I see. I removed the pointed part.

@ofborg ofborg bot added the 6.topic: python label Feb 14, 2020
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Feb 14, 2020

if you just need the executable, we can move this out of python-modules and you can do the version pinning, but as it stands, this isn't ready to go into nixpkgs:

[2 built (2 failed), 3 copied (10.4 MiB), 1.8 MiB DL]
error: build of '/nix/store/gznsyv8vpwfavrkzscfi98qk1cmab314-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/80134
2 package failed to build:
python37Packages.robotframework-debuglibrary python38Packages.robotframework-debuglibrary

1 package built:
python27Packages.robotframework-debuglibrary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.