Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] nixos/display-managers: Add DesktopNames to generated xession files #80136

Closed

Conversation

@worldofpeace
Copy link
Member

worldofpeace commented Feb 14, 2020

…op session files

Some display managers (e.g. SDDM) set the XDG_CURRENT_DESKTOP variable accroding to this parameter.
If this variable is not defined, there will be some problems (e.g. MATE doesn't have icons on the desktop).

Fixes #71427

(cherry picked from commit f7768c9)

Motivation for this change

Not have mate be weird on 20.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
…op session files

Some display managers (e.g. SDDM) set the XDG_CURRENT_DESKTOP variable accroding to this parameter.
If this variable is not defined, there will be some problems (e.g. MATE doesn't have icons on the desktop).

Fixes #71427

(cherry picked from commit f7768c9)
@worldofpeace worldofpeace requested review from hedning and jtojnar Feb 14, 2020
@worldofpeace worldofpeace changed the title [20.03] nixos/display-managers: Add DesktopNames parameter to generated deskt… [20.03] nixos/display-managers: Add DesktopNames to generated xession files Feb 14, 2020
@worldofpeace worldofpeace added this to the 20.03 milestone Feb 14, 2020
@worldofpeace worldofpeace deleted the worldofpeace:backport-79830 branch Feb 15, 2020
@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Feb 15, 2020

Just closed this in favor of #80200 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.