Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-cbindgen: upgrade cargo fetcher and cargoSha256 #80243

Merged
merged 1 commit into from Mar 17, 2020

Conversation

@bhipple
Copy link
Contributor

bhipple commented Feb 16, 2020

Infra upgrade as part of #79975; no functional change expected.

@bhipple
Copy link
Contributor Author

bhipple commented Feb 16, 2020

@GrahamcOfBorg build rust-cbindgen

Copy link
Contributor

jonringer left a comment

this seems to cause some regressions

[1 built (2 failed)]
error: build of '/nix/store/7ib1j5s2sp9z4jcyd818n7vxm1sjzk1q-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/80243
5 package failed to build:
adoptopenjdk-icedtea-web firefox-esr-68-unwrapped xulrunner mozplugger slimerjs

2 package built:
rust-cbindgen thunderbird
@bhipple
Copy link
Contributor Author

bhipple commented Feb 16, 2020

Good catch, I will take a look and see what's up. Right now my script is just running nix-build -A $attr prior to sending the PR; I think I'll bump it to do a full nix-review wip first and only open a PR if everything looks good!

@jonringer
Copy link
Contributor

jonringer commented Feb 16, 2020

I think this is the first package that I've seen which it had reverse dependencies. I think the script is fine

Infra upgrade as part of #79975; no functional change expected.
@bhipple bhipple force-pushed the bhipple:u/rust-cargo-rust-cbindgen branch from 3810e96 to 0ab1692 Mar 15, 2020
@bhipple
Copy link
Contributor Author

bhipple commented Mar 15, 2020

@jonringer I have rebased onto the latest origin/master and verified that all of these build:

λ brh nixpkgs →  nix build -L -f . adoptopenjdk-icedtea-web firefox-esr-68-unwrapped xulrunner mozplugger slimerjs thunderbird
λ brh nixpkgs →  ll result*
lrwxrwxrwx 1 bhipple users 74 Mar 15 18:20 result -> /nix/store/hvl1hg5r7mjphqllnyhgbqvb4yjawadr-adoptopenjdk-icedtea-web-1.8.3
lrwxrwxrwx 1 bhipple users 75 Mar 15 18:20 result-1 -> /nix/store/z0fn853hxf358zb41lsrqdqlfjg0kyk3-firefox-esr-unwrapped-68.6.0esr
lrwxrwxrwx 1 bhipple users 66 Mar 15 18:20 result-2 -> /nix/store/2pkpkzn75xqyqgsg0sxdcwr03f1laysa-firefox-unwrapped-74.0
lrwxrwxrwx 1 bhipple users 60 Mar 15 18:20 result-3 -> /nix/store/ga6n65nk4a7sw0lwj9dnqq3m22q7li9m-mozplugger-2.1.6
lrwxrwxrwx 1 bhipple users 58 Mar 15 18:20 result-4 -> /nix/store/lrnjp2ll3m8c1pjx2xh8qzpd608i22py-slimerjs-1.0.0
lrwxrwxrwx 1 bhipple users 62 Mar 15 18:20 result-5 -> /nix/store/s3kd4vair2b49phb8wr8kp4p2zs7wql6-thunderbird-68.6.0

This builds both firefox and the extended support version of firefox, so it takes a very long time and uses a huge amount of RAM. My suspicion is that the original nixpkgs-review just died for something like OOM killer on g++, or perhaps the rebase has fixed it. At any rate, I think this is now good for merging.

@Ma27 Ma27 merged commit e86ec10 into NixOS:master Mar 17, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
rust-cbindgen on aarch64-linux Success
Details
rust-cbindgen on x86_64-linux Success
Details
@bhipple bhipple deleted the bhipple:u/rust-cargo-rust-cbindgen branch Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.