Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacsPackages.org-roam: init at 0.1.2 #80280

Closed
wants to merge 2 commits into from

Conversation

@rasendubi
Copy link
Member

rasendubi commented Feb 16, 2020

Motivation for this change

org-roam seems to be a nice package, but it's not packaged into melpa/elpa

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I'm running it now and it works fine.

@adisbladis
Copy link
Member

adisbladis commented Feb 21, 2020

Could you try to get upstream to upload the package to elpa/melpa?

@rasendubi
Copy link
Member Author

rasendubi commented Feb 23, 2020

Sure. Asked for that in org-roam/org-roam#171

@jethrokuan
Copy link
Contributor

jethrokuan commented Feb 24, 2020

I'd like to upload to MELPA when things become more stable, which is when I decide it's version 1.0.0.

@rasendubi rasendubi changed the title emacsPackages.org-roam: init at 0.1.1 emacsPackages.org-roam: init at 0.1.2 Mar 6, 2020
@rasendubi
Copy link
Member Author

rasendubi commented Mar 6, 2020

A melpa release won't happen any time soon. The question is, do we want org-roam in nixpkgs now, or should I stash it in my overlay?

I would go for nixpkgs as org-roam is quite an active project and gets excellent traction (see pulse). I've been using 0.1.2 for two weeks now, and I find it quite stable and useful.

@adisbladis, what do you think?

@jethrokuan
Copy link
Contributor

jethrokuan commented Mar 6, 2020

A melpa release won't happen any time soon.

Within the next week I think!

@rasendubi
Copy link
Member Author

rasendubi commented Mar 6, 2020

oh wow. that's great news! I think we should wait then :)

@adisbladis
Copy link
Member

adisbladis commented Mar 6, 2020

Great! I was just going to say "let's just add it", but if a proper MELPA release is coming soon then let's wait for it :)

:fetcher github
:files ("*.el"))
'';
packageRequires = [ dash f s async ];

This comment has been minimized.

Copy link
@jethrokuan

jethrokuan Mar 6, 2020

Contributor

for when 1.0.0 lands:

Suggested change
packageRequires = [ dash f s async ];
packageRequires = [ dash f s emacsql emacsql-sqlite ];

This comment has been minimized.

Copy link
@adisbladis

adisbladis Mar 6, 2020

Member

@jethrokuan If the package is pulled from melpa all those bit's are automagic.

@adisbladis
Copy link
Member

adisbladis commented Mar 7, 2020

I'm closing this for now since the package will arrive in Nixpkgs through the usual MELPA workflow.

@adisbladis adisbladis closed this Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.