Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dolphin-emu: add update script #80450

Closed
wants to merge 1 commit into from

Conversation

@leo60228
Copy link
Contributor

leo60228 commented Feb 18, 2020

Motivation for this change

dolphinEmuMaster has been historically updated manually, usually (but not always) to a beta release. Now that there's an API used by the auto-updater, a script can be written to generate the latest dolphinEmuBeta and dolphinEmuDev.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) N/A
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after): negligible, 482766440 -> 477334048
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ashkitten
Copy link
Contributor

ashkitten commented Feb 18, 2020

this seems fine to me in order to help target the correct commit hash (only skimmed the code so far) but i don't know that there's any point in pulling the dev channel since updating more often than monthly is just extra work for reviewers without much real benefit. that's mainly just my opinion though.

@aanderse
Copy link
Contributor

aanderse commented Feb 19, 2020

I agree with @ashkitten: aren't monthly bumps sufficient?

@doronbehar
Copy link
Contributor

doronbehar commented May 23, 2020

I'm closing as OP seems not intent to respond to comments.

@doronbehar doronbehar closed this May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.