Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
lumo 1.10.1: fix missing dependency #80655
Motivation for this change
Lumo is currently failing on linux https://hydra.nixos.org/build/112812334 and a fix was merged today
this merge includes darwin support https://hydra.nixos.org/build/113308416 which is failing, I hope darwin can safely be left out here without affecting the linux support?
@worldofpeace I've been in the habit of squashing commits on the gihub.com ui, so I messed up a bit by not squashing, so I thought the merge would make sense in this case as it would encompass the changes from 2 commits. Now I've cherry picked the 2 commits, the other one titled terribly "cleanup". It's a small mess, I hope I'm forgiven :)
@Mic92 sorry about being a bit clueless, I didn't remember my changes being merged already :) so I changed the commit message to just refer to a fix. I tested locally and the binary compiles and runs fine, need to research if this patch was of any importance, but afaik, it wasn't.