Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-mfa: init at v0.0.12 #80686

Closed
wants to merge 1 commit into from
Closed

aws-mfa: init at v0.0.12 #80686

wants to merge 1 commit into from

Conversation

@pmyjavec
Copy link
Contributor

pmyjavec commented Feb 21, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

jonringer left a comment

odd they don't do an sdist

pkgs/tools/security/aws-mfa/default.nix Outdated Show resolved Hide resolved
@pmyjavec pmyjavec force-pushed the pmyjavec:master branch from 048296a to aa334c8 Feb 23, 2020
Copy link
Contributor

jonringer left a comment

personal taste, otherwise LGTM

pkgs/tools/security/aws-mfa/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/aws-mfa/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/aws-mfa/default.nix Outdated Show resolved Hide resolved
@pmyjavec
Copy link
Contributor Author

pmyjavec commented Feb 27, 2020

odd they don't do an sdist

@jonringer who is they? What's an sdist ?

@pmyjavec pmyjavec force-pushed the pmyjavec:master branch from aa334c8 to 1657fed Feb 27, 2020
@pmyjavec
Copy link
Contributor Author

pmyjavec commented Feb 27, 2020

@jonringer done,

Question, do you know why after I applied the changes you requested the following command to install the package stopped working:

nix-env -f pkgs/top-level/all-packages.nix -i aws-mfa

I have to use:

nix-env -f . -iA aws-mfa

The first example would otherwise give me the error:

error: cannot auto-call a function that has an argument without a default value ('lib')

This is actually why I didn't do it the way you suggested in the first place.
`

@jonringer
Copy link
Contributor

jonringer commented Mar 1, 2020

if you want to test a build, you shouldn't use nix-env, but rahter nix-build, and just do nix-build -A aws-mfa

@jonringer
Copy link
Contributor

jonringer commented Mar 1, 2020

@pmyjavec
Copy link
Contributor Author

pmyjavec commented Mar 1, 2020

@jonringer yeah sorry. I understand that but I was actually trying to install it as I wanted to use the package now.

@jonringer
Copy link
Contributor

jonringer commented Mar 1, 2020

@jonringer who is they?

they is upstream, the ones who created aws-mfa

What's an sdist ?

short for "source distribution", its one of the ways you can publish a package. A .whl file is a bdist_wheel format

Copy link
Contributor

jonringer left a comment

not really sure if this should be included in nixpkgs.

  • No tests
  • Last activity was two years ago

maybe this could be added in https://github.com/nix-community/NUR

@jonringer
Copy link
Contributor

jonringer commented Mar 1, 2020

If you need it locally for packaging another package, you can use an overlay https://nixos.wiki/wiki/Overlays

If you just need an environment where you can call it, you could idiomatic python method of using a venv to install and then use it within the venv. https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#how-to-consume-python-modules-using-pip-in-a-virtual-environment-like-i-am-used-to-on-other-operating-systems

@pmyjavec
Copy link
Contributor Author

pmyjavec commented Mar 17, 2020

@jonringer closing as it seems this is not wanted. Thanks.

@pmyjavec pmyjavec closed this Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.