Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-wide: Fix with nixUnstable #80775

Closed
wants to merge 4 commits into from
Closed

tree-wide: Fix with nixUnstable #80775

wants to merge 4 commits into from

Conversation

@jtojnar
Copy link
Contributor

jtojnar commented Feb 22, 2020

Motivation for this change

nix command is gated on unstable Nix, breaking our usage of that.

Supersedes: #80724

Things done

I ran nixos-rebuild switch with the following in my config:

{
  nixpkgs.overlays = [
    (self: super: {
      nix = super.nixUnstable;
    })
  ];

  nix.package = pkgs.nixUnstable;
}
  • Verified that nixos-option builds
  • Verified that system is activated correctly
  • [] Ran nixosTests.installer
jtojnar added 3 commits Feb 21, 2020
nix::baseNameOf returns std::string_view instead of std::string in unstable Nix,
which cannot be autocast to `const char*` expected by `nix::LegacyArgs::LegacyArgs` constructor.
Otherwise the command will likely fail with nix.package = nixUnstable set
since the nix-command is still experimental.
Otherwise the nix activation script fails with nix = nixUnstable overlay
since nix-command is still experimental.
@jtojnar
Copy link
Contributor Author

jtojnar commented Feb 22, 2020

Was getting the following in the installer test:

machine: must succeed: nixos-install < /dev/null >&2
machine # building the configuration in /mnt/etc/nixos/configuration.nix...
machine # error: unrecognised flag '-f'
machine # Try 'nix-build --help' for more information.

Hopefully that is all flags I have to change. --store also is not listed in documentation but it is supposed to be supported according to Eelco.

@jtojnar jtojnar requested a review from edolstra Mar 2, 2020
@jtojnar
Copy link
Contributor Author

jtojnar commented May 11, 2020

Mostly fixed in #87182

@jtojnar jtojnar closed this May 11, 2020
@jtojnar jtojnar deleted the jtojnar:nix-command branch May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.