Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

programs/chromium: allow extensions outside chrome web store #80922

Merged
merged 1 commit into from May 1, 2020

Conversation

@danielfullmer
Copy link
Contributor

danielfullmer commented Feb 23, 2020

Motivation for this change

The programs.chromium.extensions option currently appends the chrome web store update URL to the extension ID for the ExtensionInstallForcelist option. As indicated by the documentation for ExtensionInstallForcelist this is not necessary as it is already the default.

Removing this implicit default would allow a user to more easily install extensions not in the chrome web store by setting the update URL themselves. An example was also added to the documentation.

If an alternative schema for this option is desired, I am open to it. Maybe a list of { id= "..."; updateURL = "..."; } attrsets? I tried to just do a minimal change that wouldn't break any existing configs.

Also relevant to this PR is #76863 which would be nicer but probably requires a lot more work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@danielfullmer danielfullmer force-pushed the danielfullmer:chromium-extensions-fix branch from 1a32c66 to 8ae0ae5 Apr 30, 2020
@danielfullmer
Copy link
Contributor Author

danielfullmer commented Apr 30, 2020

Just removed the "bypass paywalls" example from this PR. Regardless of how you feel about paywall bypassing, the update URL changed and it's not great to have an example that 404s. This PR remains ready to merge.

@bjornfor bjornfor merged commit 2aebb23 into NixOS:master May 1, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8ae0ae5"; rev="8ae0ae5735ec922434ebbd8efb26d7f38b7097f2"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8ae0ae5"; rev="8ae0ae5735ec922434ebbd8efb26d7f38b7097f2"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8ae0ae5"; rev="8ae0ae5735ec922434ebbd8efb26d7f38b7097f2"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8ae0ae5"; rev="8ae0ae5735ec922434ebbd8efb26d7f38b7097f2"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8ae0ae5"; rev="8ae0ae5735ec922434ebbd8efb26d7f38b7097f2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8ae0ae5"; rev="8ae0ae5735ec922434ebbd8efb26d7f38b7097f2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8ae0ae5"; rev="8ae0ae5735ec922434ebbd8efb26d7f38b7097f2"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.