Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickbms: init at 0.10.1 #81023

Closed
wants to merge 1 commit into from
Closed

quickbms: init at 0.10.1 #81023

wants to merge 1 commit into from

Conversation

@bignaux
Copy link
Contributor

@bignaux bignaux commented Feb 25, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

need pkgsi686Linux for gnu/stubs-32.h.

@bignaux
Copy link
Contributor Author

@bignaux bignaux commented Feb 25, 2020

@GrahamcOfBorg build quickbms

@david-sawatzke
Copy link
Contributor

@david-sawatzke david-sawatzke commented May 31, 2020

Thanks, works great!

@bignaux Out of interest, is there a reason why you're not using fetchzip?

meta = {
description = "Files extractor and reimporter, archives and file formats parser";
homepage = "http://quickbms.com";
license = licenses.gpl2;
Copy link
Member

@ryantm ryantm Sep 24, 2020

The gpl license variants without the Plus or Only suffix are deprecated, because they do not specify the license well enough. Use Plus if the project has "or later" sections in the actual source code files (not the license). Otherwise, use the Only suffix.

See https://discourse.nixos.org/t/lib-licenses-gpl3-co-are-now-deprecated/8206 for more details.

@ryantm
Copy link
Member

@ryantm ryantm commented Sep 24, 2020

Result of nixpkgs-review pr 81023 1

1 package built:
- quickbms

@bignaux bignaux closed this Oct 13, 2020
@bignaux bignaux deleted the quickbms branch Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants