Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teensyduino: add missing dependencies for teensy-loader #81156

Merged
merged 1 commit into from Mar 7, 2020

Conversation

@rehno-lindeque
Copy link
Contributor

rehno-lindeque commented Feb 27, 2020

Motivation for this change

This is a fixed version of #75560 that adds the missing package arguments (cairo and udev) at the top of the file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

bjornfor left a comment

Code looks good, but I would like to see the commit message have the "teensyduino:" prefix.

@rehno-lindeque rehno-lindeque force-pushed the rehno-lindeque:fix/teensyduino branch from 5663fac to c16f72a Mar 6, 2020
@rehno-lindeque rehno-lindeque changed the title add missing dependencies for teensy-loader teensyduino: add missing dependencies for teensy-loader Mar 6, 2020
@rehno-lindeque
Copy link
Contributor Author

rehno-lindeque commented Mar 6, 2020

Sorry about forgetting that, I've added teensyduino: to the commit message now and rebased on master.

@rehno-lindeque rehno-lindeque force-pushed the rehno-lindeque:fix/teensyduino branch from c16f72a to 5e4c7d8 Mar 6, 2020
@ofborg ofborg bot requested a review from bjornfor Mar 6, 2020
@bjornfor bjornfor merged commit b13f878 into NixOS:master Mar 7, 2020
15 checks passed
15 checks passed
teensyduino on aarch64-linux No attempt
Details
teensyduino on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.