Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] go_1_14: init at 1.14 and switch to it (backport) #81266

Merged
merged 2 commits into from Mar 4, 2020
Merged

[20.03] go_1_14: init at 1.14 and switch to it (backport) #81266

merged 2 commits into from Mar 4, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Feb 28, 2020 •
edited

Motivation for this change

https://golang.org/doc/go1.14

There are Go releases every half a year and we had 1.13 in 19.09, so, it’ll be great to have 1.14 in 20.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@ofborg ofborg bot requested review from kalbasit, Mic92 and cstrahan February 28, 2020 06:12
@Frostman
Copy link
Member Author

Frostman commented Mar 1, 2020

cc @NixOS/nixos-release-managers

worldofpeace
worldofpeace approved these changes Mar 1, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sane to me.

@adisbladis
Copy link
Member

I'm gonna go ahead and try to build all packages and we'll see which ones fail.

@worldofpeace
Copy link
Contributor

I'm gonna go ahead and try to build all packages and we'll see which ones fail.

That's good, but it is going into staging-20.03 so we could use hydra for this https://hydra.nixos.org/jobset/nixpkgs/staging-20.03. But I guess it's also better for something to be adequately tested before merging in the first place.

@Frostman
Copy link
Member Author

Frostman commented Mar 2, 2020 •
edited

just in case I've re-tested it with nixpkgs-review: (x86_64)

2 package failed to build: act python38Packages.aria2p 730 package built

@adisbladis adisbladis merged commit 0c3057c into NixOS:staging-20.03 Mar 4, 2020
@adisbladis
Copy link
Member

adisbladis commented Mar 4, 2020 •
edited

Fixed aria2p by backporting 76079f2.

@adisbladis
Copy link
Member

Fixed act by backporting 5e75ba3 & 5e75ba3.

@Frostman Frostman deleted the 20.03-go-1.14 branch March 4, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@Mic92 Mic92 Awaiting requested review from Mic92

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
6.topic: golang 8.has: package (new) 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Frostman @adisbladis @worldofpeace