Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gleam: 0.6.0 -> 0.7.1 #81501

Closed
wants to merge 4 commits into from
Closed

gleam: 0.6.0 -> 0.7.1 #81501

wants to merge 4 commits into from

Conversation

@NobbZ
Copy link
Contributor

NobbZ commented Mar 2, 2020

Motivation for this change

Upstream release of a new version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

filalex77 left a comment

Just wanted to do this myself. Besides a nitpick, LGTM. Thanks!

@@ -1,19 +1,19 @@
{ stdenv, rustPlatform, fetchFromGitHub, Security }:
{pkgs, stdenv, rustPlatform, fetchFromGitHub, Security }:

This comment has been minimized.

@filalex77

filalex77 Mar 2, 2020 Contributor

I don't see any usage of pkgs in this file. In nixpkgs, each derivation is called (in pkgs/top-level/all-packages.nix) as

{
  name = callPackage /path/to/derivation { };
}

where callPackage allows to select dependencies via derivation arguments. Thus, you can skip pkgs. If there is any reason for why it is added here, please let me know!

This comment has been minimized.

@NobbZ

NobbZ Mar 2, 2020 Author Contributor

Of, course, I just inserted it to have access to pkgs.lib.fakeSha256 during updating the hashes, it was not meant to slip through…

@ofborg ofborg bot requested a review from filalex77 Mar 2, 2020
@NobbZ
Copy link
Contributor Author

NobbZ commented Mar 8, 2020

In the meantime 0.7.1 has been released, though it reports itself as 0.7.0 as the tag is on the wrong commit.

This has been reported upstream and might cause either a re-release from the correct tag, or just stick where we are, depending on how large the commit gap actually is.

Depending on the merge status of this PR, I will just push a change after the upstream issue has been resolved or create a new PR.

@NobbZ NobbZ changed the title gleam: 0.6.0 -> 0.7.0 gleam: 0.6.0 -> 0.7.1 Mar 8, 2020
@NobbZ
Copy link
Contributor Author

NobbZ commented Mar 8, 2020

Okay, 0.7.1 got re-tagged under another commit. I have adjusted the files accordingly.

@NobbZ NobbZ requested a review from filalex77 Mar 8, 2020
@danieldk
Copy link
Member

danieldk commented Jun 30, 2020

Closing this, since we are already at 0.8.0.

#86304

@danieldk danieldk closed this Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.