Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orca-c: init at git-2020-02-12 #81547

Merged
merged 3 commits into from May 4, 2020
Merged

orca-c: init at git-2020-02-12 #81547

merged 3 commits into from May 4, 2020

Conversation

@Sohalt
Copy link
Contributor

Sohalt commented Mar 2, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Sohalt Sohalt force-pushed the Sohalt:orcac branch from 3693c0b to cfcf286 Apr 4, 2020
@grahamc
Copy link
Member

grahamc commented Apr 4, 2020

'';

meta = with stdenv.lib; {
description = "Orca is an esoteric programming language designed to quickly create procedural sequencers.";

This comment has been minimized.

Copy link
@ehmry

ehmry May 4, 2020

Member

Description must not start with the name of the package.


meta = with stdenv.lib; {
description = "Orca is an esoteric programming language designed to quickly create procedural sequencers.";
homepage = "https://github.com/hundredrabbits/Orca-c";

This comment has been minimized.

Copy link
@ehmry

This comment has been minimized.

Copy link
@Sohalt

Sohalt May 4, 2020

Author Contributor

I think that's only the homepage for the "official" electron/JS implementation. The C implementation does not get linked from there.

@ehmry ehmry merged commit 24bc2b8 into NixOS:master May 4, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1608d9f"; rev="1608d9f58ba548402226b59d99f335cd1a676289"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1608d9f"; rev="1608d9f58ba548402226b59d99f335cd1a676289"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1608d9f"; rev="1608d9f58ba548402226b59d99f335cd1a676289"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1608d9f"; rev="1608d9f58ba548402226b59d99f335cd1a676289"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1608d9f"; rev="1608d9f58ba548402226b59d99f335cd1a676289"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1608d9f"; rev="1608d9f58ba548402226b59d99f335cd1a676289"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1608d9f"; rev="1608d9f58ba548402226b59d99f335cd1a676289"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
orca-c, orca-c.passthru.tests on aarch64-linux Success
Details
orca-c, orca-c.passthru.tests on x86_64-linux Success
Details
@Sohalt
Copy link
Contributor Author

Sohalt commented May 4, 2020

Thanks!

@Sohalt Sohalt deleted the Sohalt:orcac branch May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.