Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.stem: 1.7.1 -> 1.8.0 #81679

Merged
merged 1 commit into from Mar 7, 2020
Merged

Conversation

@colemickens
Copy link
Member

colemickens commented Mar 4, 2020

Motivation for this change

This updates the python package stem to its latest stable version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@colemickens
Copy link
Member Author

colemickens commented Mar 4, 2020

[cole@xeep:~/code/nixpkgs-stem]$ nix-review rev HEAD
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
$ git worktree add /home/cole/.cache/nixpkgs-review/rev-f539a47dabe6fd614179ee7df12d596bdab1dff9-1/nixpkgs 7aa084521b34efd71e9b17728f605011a1565a36
Preparing worktree (detached HEAD 7aa084521b3)
Updating files: 100% (21112/21112), done.
HEAD is now at 7aa084521b3 Merge pull request #81694 from r-ryantm/auto-update/liblouis
$ nix-env -f /home/cole/.cache/nixpkgs-review/rev-f539a47dabe6fd614179ee7df12d596bdab1dff9-1/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit f539a47dabe6fd614179ee7df12d596bdab1dff9
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/cole/.cache/nixpkgs-review/rev-f539a47dabe6fd614179ee7df12d596bdab1dff9-1/nixpkgs -qaP --xml --out-path --show-trace --meta
derivation 'gnome-tour-0.0.1' has invalid meta attribute 'override'
derivation 'gnome-tour-0.0.1' has invalid meta attribute 'overrideDerivation'
7 package updated:
nyx onioncircuits python2.7-stem (1.7.1 → 1.8.0) python3.7-stem (1.7.1 → 1.8.0) python3.8-stem (1.7.1 → 1.8.0) qutebrowser tor-exporter

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/cole/.cache/nixpkgs-review/rev-f539a47dabe6fd614179ee7df12d596bdab1dff9-1/build.nix
[9 built, 312 copied (1488.4 MiB), 328.1 MiB DL]
7 package built:
nyx onioncircuits prometheus-tor-exporter python27Packages.stem python37Packages.stem python38Packages.stem qutebrowser

$ nix-shell /home/cole/.cache/nixpkgs-review/rev-f539a47dabe6fd614179ee7df12d596bdab1dff9-1/shell.nix


@marsam
Copy link
Contributor

marsam commented Mar 7, 2020

@GrahamcOfBorg build qutebrowser

@marsam marsam merged commit 9d44f2f into NixOS:master Mar 7, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
qutebrowser on aarch64-linux Success
Details
qutebrowser on x86_64-linux Success
Details
@marsam
Copy link
Contributor

marsam commented Mar 7, 2020

Thanks!

ryneeverett added a commit to ryneeverett/nixpkgs that referenced this pull request Apr 25, 2020
A third attempt after NixOS#85642 which I hadn't recognized as a backport
of NixOS#81679.

The bug is just with the test suite on python 3.8 which was fixed in 1.8.0.
See bug report: https://trac.torproject.org/projects/tor/ticket/30847.

(cherry picked from commit 618cdd2)
@ryneeverett ryneeverett mentioned this pull request Apr 25, 2020
3 of 10 tasks complete
stigok added a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
A third attempt after NixOS#85642 which I hadn't recognized as a backport
of NixOS#81679.

The bug is just with the test suite on python 3.8 which was fixed in 1.8.0.
See bug report: https://trac.torproject.org/projects/tor/ticket/30847.

(cherry picked from commit 618cdd2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.