Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toggldesktop: take mkDerivation as input #81720

Merged
merged 2 commits into from Mar 17, 2020
Merged

Conversation

@int-index
Copy link
Contributor

int-index commented Mar 4, 2020

Motivation for this change

I was investigating why toggldesktop wasn't working for me. Running it results in the following error:

$ QT_DEBUG_PLUGINS=1 toggldesktop
QFactoryLoader::QFactoryLoader() checking directory path "/run/wrappers/lib/qt-5.12.7/plugins/platforms" ...
QFactoryLoader::QFactoryLoader() checking directory path "/home/int-index/.nix-profile/lib/qt-5.12.7/plugins/platforms" ...
QFactoryLoader::QFactoryLoader() checking directory path "/etc/profiles/per-user/int-index/lib/qt-5.12.7/plugins/platforms" ...
QFactoryLoader::QFactoryLoader() checking directory path "/nix/var/nix/profiles/default/lib/qt-5.12.7/plugins/platforms" ...
QFactoryLoader::QFactoryLoader() checking directory path "/run/current-system/sw/lib/qt-5.12.7/plugins/platforms" ...
QFactoryLoader::QFactoryLoader() checking directory path "/nix/store/9527zk7zkwjxhpabkgd7b3q2anm8p6zd-toggldesktop-7.5.42-unwrapped/platforms" ...
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

[1]    29789 abort (core dumped)  QT_DEBUG_PLUGINS=1 toggldesktop

According to https://nixos.wiki/wiki/Qt the fix is to use wrapQtAppsHook, which is added by Qt5's mkDerivation. That's also what #65399 (comment) says.

Unfortunately, this change does not fix toggldesktop. I'm submitting because it seems like the right thing to do anyway, and to ask if there are other things I could try. cc @yegortimoshenko @ttuegel

Things done
  • Use latest version
  • Use Qt5 mkDerivation
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ttuegel
ttuegel approved these changes Mar 8, 2020
@ttuegel
Copy link
Member

ttuegel commented Mar 8, 2020

I will wait for @yegortimoshenko to review, because this pull request increments the version, but the other aspects look good to me!

Tha sha256 in src was not updated.
@veprbl
Copy link
Member

veprbl commented Mar 17, 2020

@GrahamcOfBorg build toggldesktop

@veprbl veprbl merged commit bfcb191 into NixOS:master Mar 17, 2020
14 of 16 checks passed
14 of 16 checks passed
toggldesktop on aarch64-linux
Details
toggldesktop on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
toggldesktop on x86_64-linux Success
Details
veprbl added a commit that referenced this pull request Mar 18, 2020
(cherry picked from commit bfcb191)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.