Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/prometheus-mikrotik-exporter: init #81857

Merged
merged 2 commits into from Mar 6, 2020

Conversation

@mmilata
Copy link
Contributor

mmilata commented Mar 6, 2020

Adds package and module for https://github.com/nshttpd/mikrotik-exporter

Motivation for this change

Some information is not exposed through SNMP:(

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mmilata mmilata force-pushed the mmilata:prometheus-mikrotik-exporter branch from 8d24c26 to 8a8fef4 Mar 6, 2020
@mmilata mmilata force-pushed the mmilata:prometheus-mikrotik-exporter branch from 8a8fef4 to 421a18f Mar 6, 2020
@WilliButz

This comment has been minimized.

Copy link
Member

WilliButz commented Mar 6, 2020

@GrahamcOfBorg test prometheus-exporters.mikrotik

@WilliButz WilliButz merged commit 3cd57cf into NixOS:master Mar 6, 2020
2 checks passed
2 checks passed
tests.prometheus-exporters.mikrotik on aarch64-linux Success
Details
tests.prometheus-exporters.mikrotik on x86_64-linux Success
Details
@mmilata mmilata deleted the mmilata:prometheus-mikrotik-exporter branch Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.