Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #81873: xsession file generated for xmonad blocks on xmonad if the configuration is set #81876

Closed
wants to merge 1 commit into from

Conversation

@poscat0x04
Copy link
Contributor

@poscat0x04 poscat0x04 commented Mar 6, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@vcunat vcunat changed the title fix https://github.com/NixOS/nixpkgs/issues/81873 fix #81873: xsession file generated for xmonad blocks on xmonad if the configuration is set Mar 6, 2020
@sepiabrown
Copy link
Contributor

@sepiabrown sepiabrown commented Mar 15, 2020

export commands in between the xmonad command and desktop session command seem to not get exported!

check it by implementing the below code in configuration.nix

      services.xserver.windowManager.session = mkForce [{
        name = "xmonad";
        start = if (cfg.config != null) then ''
           ${xmonadBin} &
           waitPID = $!
        '' else ''
           systemd-cat -t xmonad ${xmonad}/bin/xmonad & 
           waitPID = $!
        '';
      }];

I think we should fix the below part to make export commands be on top of xmonad command and desktop session command. Or there might be better solution to this! Is it possible to make export commands in between other commands?

xsession = dm: wm: pkgs.writeScript "xsession" ''
#! ${pkgs.bash}/bin/bash
# Legacy session script used to construct .desktop files from
# `services.xserver.displayManager.session` entries. Called from
# `sessionWrapper`.
# Start the window manager.
${wm.start}
# Start the desktop manager.
${dm.start}
${optionalString cfg.updateDbusEnvironment ''
${lib.getBin pkgs.dbus}/bin/dbus-update-activation-environment --systemd --all
''}

@sepiabrown
Copy link
Contributor

@sepiabrown sepiabrown commented Mar 16, 2020

Ok, i think this is an issue only for mate-desktop so I will issue a new issue.

@stale
Copy link

@stale stale bot commented Sep 12, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@poscat0x04
Copy link
Contributor Author

@poscat0x04 poscat0x04 commented Oct 31, 2020

this has been fixed

@poscat0x04 poscat0x04 closed this Oct 31, 2020
@poscat0x04 poscat0x04 deleted the fix-xmonad-startup branch Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants